[debian-mysql] mysql-5.7 remove dojo patch

Robie Basak robie.basak at ubuntu.com
Tue Nov 8 11:31:30 UTC 2016


Hi Bjoern,

On Tue, Nov 08, 2016 at 11:10:10AM +0000, Bjoern Boschman wrote:
> there's a option to repack upstream source.
> I've created a branch that would include these changes:
> https://anonscm.debian.org/cgit/pkg-mysql/mysql.git/log/?h=mysql-5.7/repack-no-ndb-frontend
> What do you and the rest of the team think about this approach?

Thank you for proposing the branch!

Repacking causes some additional pain for various reasons (eg. cannot
necessarily reproduce the same bit-identical tarball, so really only a
DD uploader should be producing it, so it can't be committed to the VCS
in advance since an uploader cannot be sure it isn't trojaned without
tedious verification). It's easier to stick to the upstream's release
tarball when possible.

So I'd prefer to avoid repacking, which is why we tried to do it with
quilt in the first place IIRC. Technically AFAIK these files aren't
actually non-DSFG to redistribute so are permitted to be part of the
Debian source package; we just don't want them to form part of the
binary packages for policy reasons ("binaries must be buildable from
source that is non-minified", etc).

OTOH, if maintaining the quilt patch (and lintian overrides, etc) is
really becoming painful, then I'm fine with resorting to repacking if we
have to do it. And your use of Files-Excluded in debian/copyright is the
way I'd expect it to be done in this case - thanks.

If you do push this, then please don't push the pristine-tar branch to
VCS yourself any more since then the first uploader of a particular
upstream version will have to spend extra effort verifying it.

That's my opinion anyway. I'd prefer not to do it this way, but if the
only people maintaining the exclusions want it this way, then fine.

Lars, what's your opinion?

Please could you keep debian/changelog changes in separate commits
though please? This makes cherry-picking easier. IOW, don't change
debian/changelog in anything but its own commit, and there's no need to
update debian/changelog except before upload (we'll use git-dch to
create changelog entries from git commit logs). We had a thread about
this a while back.

Robie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-mysql-maint/attachments/20161108/20254c66/attachment.sig>


More information about the pkg-mysql-maint mailing list