[debian-mysql] MariaDB 10.6 for Debian packaged

[Otto Kekäläinen]

Thanks for the review! Comments inline.

On Tue, Oct 26, 2021 at 1:03 AM Tuukka Pasanen <tuukka.pasanen at ilmi.fi> wrote:
>
> Hello,
> I've looked GIT commits and they in very good shape.
> Some observations that rise to my mind:
>  * I didn't know that one can do [mariadb-10.6] config that is only for some version of MariaDB is this documented somewhere?

I don't know actually. This was in all previous MariaDB versions, not
sure where it came from.

>  * What is (I admit didn't grep) source_mariadb-10.6.py used for? As it seems to parse logs..

It is the script Apport in Ubuntu uses to make automatic bug reports
on mariadbd crashes in Launchpad.

>  * In pipeline there is nice upgrade tests.. what Database they are using or just create database and upgrade. I try to find these Salsa tests to study them more.
>  * Ok seems that upstream tests should be fixed as they are borked currently!
>  * In future would it be 'convenient' to use just mariadb-server.postinst and other without 10.6/7/8 suffix. I know it's just copy with git but there are tags and releases to make sure
>    that files get into correct place. This just my humble opinion nothing more.

Yes, there has been discussions to drop the version specific suffixes.
They have been in the packaging since the start (inherited from MySQL)
but I rarely hear people using them. I think there was a Debian bug
and/or upstream MDEV about this effort, but can't find it right now.

> Pipeline is actually failing currently in Salsa. I'll compile that also today and tell if it's success or not. I don't see that much changes from 10.5 why it shouldn't build.

Yes, because a new upstream Lintian check (or an old one that was
bumped from warning to error). Not related to 10.6 changes.