Bug#318664: [Pkg-nagios-devel] Bug#285554: acknowledged by developer (check_smtp update)

Jeroen van Wolffelaar jeroen at wolffelaar.nl
Sun Oct 9 21:27:53 UTC 2005


On Sun, Oct 09, 2005 at 04:40:37PM -0400, sean finney wrote:
> however, if you could address the issues in the ntp-related
> bugs (verifying the old patch is still valid, and any additional
> patching/removal of code you'd recommend for the ntpdate stuff), i'd be
> very appreciative.

Hm, it seems that ntpq output is purely used for things not available from
ntpdate. So ntpdate cannot be ripped out easily without rewriting the data
gathering from ntpdate output to gathering the same data from ntpq output. If
ntpdate is really deprecated, something to pass along upstream, I'd say (true
in general for these bugs, I might add).

That said, my patch in #268044 should still apply manually -- while the regex
has changed, it became stricter rather than more lenient, and the point stands
that the exact format of each column really doesn't matter and only makes
things more fragile, and only the contents of those columns that are actually
used matter (2, 4 and 11). So also the current regex can be replaced by the
one I proposed in #268044.

Thanks,
--Jeroen

-- 
Jeroen van Wolffelaar
Jeroen at wolffelaar.nl (also for Jabber & MSN; ICQ: 33944357)
http://Jeroen.A-Eskwadraat.nl




More information about the Pkg-nagios-devel mailing list