Bug#318664: [Pkg-nagios-devel] Bug#285554: acknowledged by developer (check_smtp update)

[Steve Greenland]

On 09-Oct-05, 16:27 (CDT), Jeroen van Wolffelaar <jeroen at wolffelaar.nl> wrote: 
> That said, my patch in #268044 should still apply manually -- while the regex
> has changed, it became stricter rather than more lenient, and the point stands
> that the exact format of each column really doesn't matter and only makes
> things more fragile, and only the contents of those columns that are actually
> used matter (2, 4 and 11). So also the current regex can be replaced by the
> one I proposed in #268044.

The problem with this bug is not the bad regex, the problem is the
assumption that offset==0 is an error, and the assumption that offset is
actually a useful check. The correct check is to determine if the site
being tested is synced with a peer, and that info is available via ntpq.

Steve
-- 
Steve Greenland
    The irony is that Bill Gates claims to be making a stable operating
    system and Linus Torvalds claims to be trying to take over the
    world.       -- seen on the net