[Pkg-nagios-devel] Bug#408231: nagios2-common: the main script /etc/init.d/nagios2 has commented lines about retrying to stop the service

[Teodor]

Package: nagios2-common
Version: 2.6-2
Severity: minor
Tags: patch


In the main script /etc/init.d/nagios2 we have these lines:

stop () {
    if [ -n "$PID" ]; then
      kill -15 -"$PID"
      ret=$?
#      sleep 1
#      if kill -0 "$PID" 2>/dev/null; then
#        ret=$?
#        log_progress_msg "Waiting . "
#        cnt=0
#        while kill -0 "$PID" 2>/dev/null; do
#          ret=$?
#          cnt=`expr "$cnt" + 1`
#          if [ "$cnt" -gt 15 ]; then
#            kill -9 -"$PID"
#            break
#          fi
#          sleep 2
#          log_progress_msg ". "
#        done
#      fi
    else

In most cases the 'stop' action is working only with the SIG_TERM (15)
send to the running process, but it would be good to retry stopping the
service in the case the first attempt failed.

It seems to me that the code is commented by mistake, otherwise it would
be deleted from the main script.

Thanks

-- System Information:
Debian Release: 4.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-3-686
Locale: LANG=ro_RO.UTF-8, LC_CTYPE=ro_RO.UTF-8 (charmap=UTF-8)

Versions of packages nagios2-common depends on:
ii  adduser          3.101                   Add and remove users and groups
ii  apache2          2.2.3-3.2               Next generation, scalable, extenda
ii  apache2-mpm-pref 2.2.3-3.2               Traditional model for Apache HTTPD
ii  coreutils        5.97-5                  The GNU core utilities
ii  debconf [debconf 1.5.11                  Debian configuration management sy
ii  lsb-base         3.1-22                  Linux Standard Base 3.1 init scrip
ii  mailx            1:8.1.2-0.20050715cvs-1 A simple mail user agent
ii  nagios-plugins-b 1.4.5-1                 Plugins for the nagios network mon
ii  nagios2-doc      2.6-2                   documentation for nagios2
ii  ucf              2.0018                  Update Configuration File: preserv

Versions of packages nagios2-common recommends:
pn  nagios-images                 <none>     (no description available)
pn  nagios-plugins                <none>     (no description available)

-- debconf information:
  nagios2/httpd: apache2
  nagios2/nagios1-in-apacheconf: false
  nagios2/adminpassword-mismatch: