Bug#408231: [Pkg-nagios-devel] Bug#408231: nagios2-common: the main script /etc/init.d/nagios2 has commented lines about retrying to stop the service

[Marc Haber]

On Wed, Jan 24, 2007 at 12:47:40PM +0200, Teodor wrote:
> In the main script /etc/init.d/nagios2 we have these lines:
> 
> stop () {
>     if [ -n "$PID" ]; then
>       kill -15 -"$PID"
>       ret=$?
> #      sleep 1
> #      if kill -0 "$PID" 2>/dev/null; then
> #        ret=$?
> #        log_progress_msg "Waiting . "
> #        cnt=0
> #        while kill -0 "$PID" 2>/dev/null; do
> #          ret=$?
> #          cnt=`expr "$cnt" + 1`
> #          if [ "$cnt" -gt 15 ]; then
> #            kill -9 -"$PID"
> #            break
> #          fi
> #          sleep 2
> #          log_progress_msg ". "
> #        done
> #      fi
>     else
> 
> In most cases the 'stop' action is working only with the SIG_TERM (15)
> send to the running process, but it would be good to retry stopping the
> service in the case the first attempt failed.
> 
> It seems to me that the code is commented by mistake, otherwise it would
> be deleted from the main script.

I suspect that I copied that code from some other packages and then
left it commented out just in case that nagios needs this more
elaborate handling as well.

fwiw, I did not find any revision of the init script in svn that had
this code present _and_ enabled. I am now tempted to treat this as a
non-bug and close it.

What exactly do you suggest doing?

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835