[Pkg-nagios-devel] Bug#990376: vim-icinga2: please migrate to dh-vim-addon

[Louis-Philippe Véronneau]

tags -1 patch
thanks

On 2021-06-28 00 h 34, Sebastiaan Couwenberg wrote:
> Control: tags -1 moreinfo
> 
> On 6/27/21 8:48 PM, Louis-Philippe Véronneau wrote:
>> Debian now has dh-vim-addon [1] to manage the installation procedure of
>> vim packages. It does "the right thing" (makes vim packages suitable for
>> the "new" vim :packadd feature) and generally helps make all vim
>> packages consistent.
>>
>> Please consider migrating to it.
>>
>> Here's an example of a package using it:
>>
>> https://salsa.debian.org/vim-team/vim-gitgutter/-/tree/master/debian
> 
> It's not clear how the icing2 packaging should be changed to use
> dh-vim-addon and how that benefits the icinga2 packaging.
> 
> The packaging already installs the vim bits in
> usr/share/vim/{registry,addons/{ftdetect,syntax}}.
> 
> If I understand the gitgutter example correctly, those files should be
> moved to somewhere under /usr/share/icinga2 and that path used in
> vim-icinga2.vim-addon.>
> The upstream packaging for packages.icinga.com is unlikely to use the
> addon because it's not available for oldstable. Hence I'm hesitant to
> adopt it in Debian and further diverge from upstream.

I think there's a lot of value in using dh-foo tooling, as it
standardizes packaging and provides a single, central utility to update
when something needs to be changed.

I do understand the argument about not wanting to diverge too much from
the upstream package though and in the end, that's your decision :)

I've included a patch to make the change I'm proposing. I've tested it
and it works as intended. Hopefully, it will provide you with the info
you requested. FWIW, the install tree looks like this:

-------------------------------------
./
./usr/
./usr/share/
./usr/share/doc/
./usr/share/doc/vim-icinga2/
./usr/share/doc/vim-icinga2/changelog.Debian.gz
./usr/share/doc/vim-icinga2/changelog.gz
./usr/share/doc/vim-icinga2/copyright
./usr/share/icinga2/
./usr/share/icinga2/vim/
./usr/share/icinga2/vim/ftdetect/
./usr/share/icinga2/vim/ftdetect/icinga2.vim
./usr/share/icinga2/vim/syntax/
./usr/share/icinga2/vim/syntax/icinga2.vim
./usr/share/nvim/
./usr/share/nvim/site/
./usr/share/nvim/site/pack/
./usr/share/nvim/site/pack/dist-bundle/
./usr/share/nvim/site/pack/dist-bundle/start/
./usr/share/nvim/site/pack/dist-bundle/start/icinga2 ->
../../../../../icinga2/vim
./usr/share/vim/
./usr/share/vim/vimfiles/
./usr/share/vim/vimfiles/pack/
./usr/share/vim/vimfiles/pack/dist-bundle/
./usr/share/vim/vimfiles/pack/dist-bundle/start/
./usr/share/vim/vimfiles/pack/dist-bundle/start/icinga2 ->
../../../../../icinga2/vim
-------------------------------------

Those changes can certainly be made "by hand" too, but IMO it's more
manual work and could lead to more work in the future if the vim best
practices change again.

Cheers, and thanks for maintaining icinga2 in Debian.

-- 
  ⢀⣴⠾⠻⢶⣦⠀
  ⣾⠁⢠⠒⠀⣿⡁  Louis-Philippe Véronneau
  ⢿⡄⠘⠷⠚⠋   pollo at debian.org / veronneau.org
  ⠈⠳⣄
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Migrate-vim-icinga2-to-dh-vim-addon.patch
Type: text/x-patch
Size: 3925 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-nagios-devel/attachments/20210701/23fe05cc/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 228 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-nagios-devel/attachments/20210701/23fe05cc/attachment.sig>