[Pkg-opencl-devel] New cl2.hpp release

[Andreas Beckmann]

On 2015-10-23 20:34, James Price wrote:
> FYI, there’s a new release of cl2.hpp in the Khronos public SVN that fixes several issues. There aren’t any changes to any of the other headers in that SVN snapshot.
> 
> There’s still a couple of bugs in that release that I’ve just fixed upstream (not public), but these probably won’t be pushed out publicly for a little while now. They’re small changes, and I can provide patches for them if we want to fix them in the Debian package in the meantime.

It's nice to have someone with upstream relationship on the team!
Since I don't know anything about the nature of these bugs/patches,
I'll let you judge whether we should have them fixed in Debian.

> This package is now hosted in pkg-opencl so I could make the update and add the patches, but I’m not sure what the etiquette for team maintenance is (e.g. are these updates something I should just go ahead and do, or should it be Andreas that handles this)?

I've just imported the new snapshot, but you are free to do this 
yourself in the future. If there is anything where you don't have the 
confidence about pushing it to master immediately (let's say, e.g.,
the first 2.1 bits) - just put it on a branch and we can discuss how
to proceed.
Once things are in git, you should drop a note to the list whether
that is ready for upload or needs to wait for ... or needs more work
on ... for ... reason.

Right now I see this during the header compile tests, which
seems to be new:

./CL/cl2.hpp:389:109: note: #pragma message: cl2.hpp: CL_HPP_TARGET_OPENCL_VERSION is not defined. It will default to 200 (OpenCL 2.0)

I don't have the time right now to dig into this deeper.
Given that we will need to add some defines, I'd suggest to change 
debian/t/Makefile like this: (the intention is to compile for each
of the supported standards (and their respective deprecation modes),
to detect if someone introduced a syntax error, again):

...
OPENCLFLAGS_1_0	= -DTHIS10 -DTHAT10 ...
OPENCLFLAGS_1_1 = ...
OPENCLFLAGS_1_2 = ...
OPENCLFLAGS_2_0 = ...
...
check:
        $(MAKE) compile_opencl_h
        $(MAKE) compile_opencl_h OPENCLFLAGS="$(OPENCLFLAGS_1_0)"
        $(MAKE) compile_opencl_h OPENCLFLAGS="$(OPENCLFLAGS_1_1)"
	...
        $(MAKE) compile_cl_hpp
        $(MAKE) compile_cl_hpp OPENCLFLAGS="$(OPENCLFLAGS_1_0)"
        $(MAKE) compile_cl_hpp OPENCLFLAGS="$(OPENCLFLAGS_1_1)"
	...
...

Andreas