[Pkg-opencl-devel] New cl2.hpp release

[James Price]

> On 23 Oct 2015, at 23:37, Andreas Beckmann <anbe at debian.org> wrote:
> 
> On 2015-10-23 20:34, James Price wrote:
>> FYI, there’s a new release of cl2.hpp in the Khronos public SVN that fixes several issues. There aren’t any changes to any of the other headers in that SVN snapshot.
>> 
>> There’s still a couple of bugs in that release that I’ve just fixed upstream (not public), but these probably won’t be pushed out publicly for a little while now. They’re small changes, and I can provide patches for them if we want to fix them in the Debian package in the meantime.
> 
> It's nice to have someone with upstream relationship on the team!
> Since I don't know anything about the nature of these bugs/patches,
> I'll let you judge whether we should have them fixed in Debian.

OK, I’ve added a patch for one of the bugs which was somewhat serious (multiply defined symbol if cl2.hpp included by multiple source files). The other bug shouldn’t be an issue for Debian.

> Right now I see this during the header compile tests, which
> seems to be new:
> 
> ./CL/cl2.hpp:389:109: note: #pragma message: cl2.hpp: CL_HPP_TARGET_OPENCL_VERSION is not defined. It will default to 200 (OpenCL 2.0)
> 
> I don't have the time right now to dig into this deeper.
> Given that we will need to add some defines, I'd suggest to change 
> debian/t/Makefile like this: (the intention is to compile for each
> of the supported standards (and their respective deprecation modes),
> to detect if someone introduced a syntax error, again):
> 
> ...
> OPENCLFLAGS_1_0	= -DTHIS10 -DTHAT10 ...
> OPENCLFLAGS_1_1 = ...
> OPENCLFLAGS_1_2 = ...
> OPENCLFLAGS_2_0 = ...
> ...
> check:
>        $(MAKE) compile_opencl_h
>        $(MAKE) compile_opencl_h OPENCLFLAGS="$(OPENCLFLAGS_1_0)"
>        $(MAKE) compile_opencl_h OPENCLFLAGS="$(OPENCLFLAGS_1_1)"
> 	...
>        $(MAKE) compile_cl_hpp
>        $(MAKE) compile_cl_hpp OPENCLFLAGS="$(OPENCLFLAGS_1_0)"
>        $(MAKE) compile_cl_hpp OPENCLFLAGS="$(OPENCLFLAGS_1_1)"
> 	...
> …

I’ve updated the Makefile with approximately this approach. The cl2.hpp tests need a different set of flags to the plain cl.h tests, since the new macros required by cl2.hpp will automatically take care of the deprecation flags.

Ready to upload from my perspective, unless there’s any issues with the changes I’ve made.

James