[Pkg-openldap-devel] Recommendation for ldbm to bdb

[Torsten Landschoff]

--6TrnltStXW4iwmi0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Matthijs,=20

I looked at your patch again. I am willing to apply it mostly unchanged.
However, there is one thing I did not like:=20

> Index: debian/slapd.postinst
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- debian/slapd.postinst	(revision 555)
> +++ debian/slapd.postinst	(working copy)
> @@ -43,6 +43,7 @@
>  if database_format_changed; then
>  	# During upgrading we have to load the old data
>  	move_incompatible_databases_away
> +	configure_ldbm_to_bdb
>  	load_databases
>  fi

This looks good - but:


On Wed, May 18, 2005 at 08:56:22AM +0200, Matthijs Mohlmann wrote:
> Index: debian/slapd.scripts-common
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- debian/slapd.scripts-common	(revision 555)
> +++ debian/slapd.scripts-common	(working copy)
[function database_format_changed]
> @@ -66,7 +76,12 @@
>  # Return success if yes.
>  # Usage: if database_format_changed; then
> =20
> -	dpkg --compare-versions "$OLD_VERSION" lt-nl "2.2.23" || return 1
> +	db_get slapd/backend_recommendation
> +	if dpkg --compare-versions "$OLD_VERSION" lt-nl "2.2.23" || [ "$RET" =
=3D "true" ]; then
> +		return 0
> +	else
> +		return 1
> +	fi
>  }

So it seems like database_format_changed tries to read the debconf
values for backend_recommendation, which are set conditionally based
on the result of database_format_changed.=20

Does not look senseful :) I'll fix that and apply your patch.

Ah, and I think the debconf option has to change if we don't implement
this generally. I don't like "backend_recommendation" for that name and=20
think about changing it to "convert_ldbm_to_bdb" or something.

Comments?

Greetings

	Torsten

--6TrnltStXW4iwmi0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFCliJ5dQgHtVUb5EcRAgrcAJ0bX2Y+2J+5ZQUJGoUkboMp/b0l3ACfYF9u
/xNIY+3xACiCBVa6ljoivqg=
=6BX3
-----END PGP SIGNATURE-----

--6TrnltStXW4iwmi0--