[Pkg-openldap-devel] Recommendation for ldbm to bdb

[Matthijs Mohlmann]

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig4881C478FDE0ACB1343D03AD
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Hi,

Torsten Landschoff wrote:
> Hi Matthijs, 
> 
> I looked at your patch again. I am willing to apply it mostly unchanged.
> However, there is one thing I did not like: 
> 
> 
>>Index: debian/slapd.postinst
>>===================================================================
>>--- debian/slapd.postinst	(revision 555)
>>+++ debian/slapd.postinst	(working copy)
>>@@ -43,6 +43,7 @@
>> if database_format_changed; then
>> 	# During upgrading we have to load the old data
>> 	move_incompatible_databases_away
>>+	configure_ldbm_to_bdb
>> 	load_databases
>> fi
> 
> 
> This looks good - but:
> 

Thanks.
> 
> On Wed, May 18, 2005 at 08:56:22AM +0200, Matthijs Mohlmann wrote:
> 
>>Index: debian/slapd.scripts-common
>>===================================================================
>>--- debian/slapd.scripts-common	(revision 555)
>>+++ debian/slapd.scripts-common	(working copy)
> 
> [function database_format_changed]
> 
>>@@ -66,7 +76,12 @@
>> # Return success if yes.
>> # Usage: if database_format_changed; then
>> 
>>-	dpkg --compare-versions "$OLD_VERSION" lt-nl "2.2.23" || return 1
>>+	db_get slapd/backend_recommendation
>>+	if dpkg --compare-versions "$OLD_VERSION" lt-nl "2.2.23" || [ "$RET" = "true" ]; then
>>+		return 0
>>+	else
>>+		return 1
>>+	fi
>> }
> 
> 
> So it seems like database_format_changed tries to read the debconf
> values for backend_recommendation, which are set conditionally based
> on the result of database_format_changed. 
> 
I don't understand what you mean by that ? Can you explain ?

> Does not look senseful :) I'll fix that and apply your patch.
> 
> Ah, and I think the debconf option has to change if we don't implement
> this generally. I don't like "backend_recommendation" for that name and 
> think about changing it to "convert_ldbm_to_bdb" or something.
> 
> Comments?
> 
No problem at all.

> Greetings
> 
> 	Torsten

Regards,

Matthijs Mohlmann

--------------enig4881C478FDE0ACB1343D03AD
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFClijY2n1ROIkXqbARAiBdAJ0TscJUTj6hsJg7zWCFpqNN7AiNmQCglTOI
s1emeOUHQjiVSUNILueL08s=
=z5Iu
-----END PGP SIGNATURE-----

--------------enig4881C478FDE0ACB1343D03AD--