[Pkg-openldap-devel] Bug#397722: slapd: ppolicy.c improperly discards return value of check_password() function

[Lee Sheridan]

Package: slapd
Version: 2.3.27-1
Severity: normal

In servers/slapd/overlays/ppolicy.c, check_password_quality function, at
line 530, the value of the 'ok' variable is discarded by unconditionally
assigning it the value LDAP_SUCCESS.

The variable is the return code of the user-defined check_password() function,
which is assigned at line 522.  The next if-then-else block is checking to
see if the module reported an error, at which point 'ok' would be assigned
LDAP_OTHER regardless of what check_password() returned.  A superfluous else
block appears after this check, assigning 'ok' to LDAP_SUCCESS.

It works fine for me if I remove the else block.


-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17-2-686
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

Versions of packages slapd depends on:
ii  adduser                 3.99             Add and remove users and groups
ii  coreutils               5.97-5           The GNU core utilities
ii  debconf [debconf-2.0]   1.5.6            Debian configuration management sy
ii  libc6                   2.3.6.ds1-4      GNU C Library: Shared libraries
ii  libdb4.2                4.2.52+dfsg-1    Berkeley v4.2 Database Libraries [
ii  libiodbc2               3.52.4-3         iODBC Driver Manager
ii  libldap-2.3-0           2.3.27-1         OpenLDAP libraries
ii  libltdl3                1.5.22-4         A system independent dlopen wrappe
ii  libperl5.8              5.8.8-6.1        Shared Perl library
ii  libsasl2                2.1.19.dfsg1-0.5 Authentication abstraction library
ii  libslp1                 1.2.1-6          OpenSLP libraries
ii  libssl0.9.8             0.9.8c-3         SSL shared libraries
ii  libwrap0                7.6.dbs-11       Wietse Venema's TCP wrappers libra
ii  perl [libmime-base64-pe 5.8.8-6.1        Larry Wall's Practical Extraction 
ii  psmisc                  22.3-1           Utilities that use the proc filesy

Versions of packages slapd recommends:
pn  db4.2-util                    <none>     (no description available)
pn  libsasl2-modules              <none>     (no description available)

-- debconf information excluded