Bug#397722: [Pkg-openldap-devel] Bug#397722: slapd: ppolicy.c improperly discards return value of check_password() function

[Quanah Gibson-Mount]

--On Wednesday, November 08, 2006 7:21 PM -0500 Lee Sheridan 
<lsherida at nccs.nasa.gov> wrote:

> Package: slapd
> Version: 2.3.27-1
> Severity: normal
>
> In servers/slapd/overlays/ppolicy.c, check_password_quality function, at
> line 530, the value of the 'ok' variable is discarded by unconditionally
> assigning it the value LDAP_SUCCESS.
>
> The variable is the return code of the user-defined check_password()
> function, which is assigned at line 522.  The next if-then-else block is
> checking to see if the module reported an error, at which point 'ok'
> would be assigned LDAP_OTHER regardless of what check_password()
> returned.  A superfluous else block appears after this check, assigning
> 'ok' to LDAP_SUCCESS.
>
> It works fine for me if I remove the else block.

I would advise filing problem reports about bugs in the OpenLDAP software 
with the OpenLDAP folks, rather than debian.

<http://www.openldap.org/its/>

is the location to do so.

--Quanah


--
Quanah Gibson-Mount
Principal Software Developer
ITS/Shared Application Services
Stanford University
GnuPG Public Key: http://www.stanford.edu/~quanah/pgp.html