[Pkg-opt-media-team] Bug#748416: Conflicting return types of function CurrentMediumSize

[Michael Tautschnig]

Package: dvdisaster
Version: 0.72.4-1
Usertags: goto-cc

During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder)
the build failed with the following error. Please note that we use our research
compiler tool-chain (using tools from the cbmc package), which permits extended
reporting on type inconsistencies at link time.

[...]
Linking  : dvdisaster

file scsi-layer.c line 2007: error: conflicting function declarations "CurrentMediumSize"
old definition in module preferences file preferences.c line 24
signed int (signed int)
new definition in module scsi-layer file scsi-layer.c line 2007
signed long int (signed int get_blank_size)
make[1]: *** [dvdisaster] Error 64
make[1]: Leaving directory `/srv/jenkins-slave/workspace/sid-goto-cc-dvdisaster/dvdisaster-0.72.4'
dh_auto_build: make -j1 returned exit code 2
make: *** [build] Error 2

It seems the actual definition returns a gint64:

http://sources.debian.net/src/dvdisaster/0.72.4-1/scsi-layer.c?hl=2007#L2007

while some forward declarations where missed in some update:

http://sources.debian.net/src/dvdisaster/0.72.4-1/rs02-window.c?hl=26#L26
http://sources.debian.net/src/dvdisaster/0.72.4-1/preferences.c?hl=24#L24

Compare the current entry in scsi-layer.h:

http://sources.debian.net/src/dvdisaster/0.72.4-1/scsi-layer.h?hl=259#L259

One can only hope that the unit of measurement is not bytes, as there happen to
be media with a capacity of more than 2 GB ... The actual uses in rs02-window.c
and preferences.c will not work correctly with any value larger than this.

Best,
Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-opt-media-team/attachments/20140517/85b44e01/attachment.sig>