[Pkg-opt-media-team] Bug#748416: Conflicting return types of function CurrentMediumSize

[Carsten Gnörlich]

Hi Michael,

> During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder)
> the build failed with the following error. Please note that we use our research
> compiler tool-chain (using tools from the cbmc package), which permits extended
> reporting on type inconsistencies at link time.

Thanks for reporting this defect. Suddenly I want to use this toolchain, 
too ;-)

> It seems the actual definition returns a gint64:
>
> http://sources.debian.net/src/dvdisaster/0.72.4-1/scsi-layer.c?hl=2007#L2007
Correct. We want gint64 in all places.

> while some forward declarations where missed in some update:
>
> http://sources.debian.net/src/dvdisaster/0.72.4-1/rs02-window.c?hl=26#L26
> http://sources.debian.net/src/dvdisaster/0.72.4-1/preferences.c?hl=24#L24
Shame on me. These should be gint64, too.

> One can only hope that the unit of measurement is not bytes, as there happen to
> be media with a capacity of more than 2 GB ... The actual uses in rs02-window.c
> and preferences.c will not work correctly with any value larger than this.

Indeed, the defect will not cause an actual failure as the unit of 
measurement is 2KBytes (= one CD/DVD/BD sector). Since even a
dual layer BD is specified to have about 23.652.352 sectors, we're
still below 2^31 by a wide margin and therefore safe.

Nevertheless, I will prepare an update asap. Which will probably mean
somewhere next week, as I am currently on a travel with limited
resources.

Best regards,
   Carsten

-- 
Carsten Gnörlich * Project homepage http://www.dvdisaster.org
dvdisaster: Additional error correction for optical media.
GnuPG FP: 12B3 1535 AF90 3ADE 9E73  BA7E 5A59 0EFE F5F6 C46C