[Pkg-owncloud-maintainers] Install required locale ...

Paul van Tilburg paulvt at debian.org
Thu May 24 19:56:30 UTC 2012


On Thu, May 24, 2012 at 04:52:48PM +0200, Diederik de Haas wrote:
> On Thursday 24 May 2012 16:08:11 Thomas Müller wrote:
> > A special locale must be installed to support utf8 filenames.
> > Is there any possibility to enforce installation of en_US.UTF-8?
> 
> IMO the problem should be solved where it is located, ie owncloud.

Agreed!

> In that init() function there are some dubious 'default' settings anyway:
> - Hardcoding locale to en_US.UTF8, while hardcoding the time zone to
> Europe/Berlin doesn't make any sense to me (lately changed to UTC,
> which still doesn't make sense)

It doesn't make sense indeed.  For example, Roundcube asks the user what
to use if LANG is not set and sets it in the generated config.
(Of course, that only determines the default.  Users can set their own.)

> Note:  d-i selects the .UTF8 variant of the user choosen locale by
> default.  If the user explicitly changes that, any errors resulting
> from that are his/her problem.

Ah good, then it's not something we need to address in the packaging.
We might add a note in the README though?

> - Changing php's execution time to 60min, why? Well the comments say:
> 	//try to configure php to enable big file uploads.
> 	//this doesn´t work always depending on the webserver and php configuration.
> 	//Let´s try to overwrite some defaults anyways
> Seriously, WTF? 
> I don't know enough about php to tell if that would change a global
> php value, thereby affecting  other webapps running on the webserver. 

It will only effect this instance AFAIK, i.e. the parameters of the php
instance that is currently interpreting that code and what follows to
handle the request.

> Either way this is sth that has to be set explicitly by de
> webmaster/sysadmin who should be capable enough to tell whether that
> change would break other web apps running on that server.
> - Setting the maximum filesize to 10G, again why? Why not 1G or 100G?
> A much better way would be (imo) to query the OS for the appropriate
> values, possible set/overriden by a config file.  If neither are
> available, sure, provide defaults.

Strangely enough, this limits (and other limits) are set differently
in /var/lib/owncloud/.htaccess:
---
<IfModule mod_php5.c>
php_value upload_max_filesize 512M
php_value post_max_size 512M
php_value memory_limit 512M
<IfModule env_module>
---
This file is visible/editable from /etc/owncloud, so that makes much
more sense to have it here.

Cheers,
Paul

-- 
Using the Power of Debian GNU/Linux  | E-mail: paulvt at debian.org
Jabber/GTalk: paul at luon.net          | GnuPG key ID: 0x50064181



More information about the Pkg-owncloud-maintainers mailing list