[Pkg-owncloud-maintainers] dompdf in OwnCloud

[Adam Williamson]

On Tue, 2013-12-31 at 11:00 -0400, David Prévot wrote:
> [ Following up to the mailing list with Adam permission, please keep
>   him CC on reply. Keeping full context of the part I’m replying to for
>   people starting to follow now. ]
> 
> Le 31/12/2013 03:48, Adam Williamson a écrit :
> 
> > For now in Fedora
> > we're simply dropping phpdocx, PHPExcel and dompdf entirely, it's a lot
> > of packaging work to get them all un-bundled for the rather minor return
> > of MS Office previews. I think we'd be happy to leave them out for the
> > medium term, there's more important stuff to deal with first. I think I
> > was slightly off the mark about tcpdf - in fact if anything it's tcpdf
> > that lifts right out, I can't quite figure out why phpdocx is actually
> > carrying a copy of it, I can't see anywhere it actually *uses* it. If
> > you have any insight that'd be a help!
> 
> It’s actually dompdf itself (shipped in phpdocx) that could use tcpdf as
> a backend, 

I know that, but it wasn't entirely clear that this is why phpdocx
includes a copy of tcpdf. dompdf doesn't ship with tcpdf itself, and
other things that embed dompdf don't necessarily also include tcpdf. So,
I had that as a possible theory, but wasn't sure it was the reason. Do
you know for sure that this is in fact the reason? If so, it makes
things easier for sure, as it just lifts right out...

> > It looks like you already have
> > everything we have - the only path patch we have that you don't is for
> > Pimple, but I'm not sure if you've unbundled that (yet).
> 
> Indeed we haven’t unbundled it yet (it’s really a short one IIRC), but
> I’d appreciate a few pointers to what you’ve already done (I’m a bit
> lost in Fedora-land, but I’m confident I’ll be able to navigate if I
> have an idea about where to start with).

So, the best web 'portal' would I guess be pkgdb, though I don't really
use it much myself:

https://admin.fedoraproject.org/pkgdb/acls/name/owncloud

note the links to 'Package Info' and 'Package Source'. 'Package Source'
will take you to the git repo where we keep our actual package builds,
I'll assume you can read a spec file well enough to steal the relevant
bits, but yell if you can't :)

Our git repos are branched per fedora release, 'master' is Rawhide (like
sid), that's probably the most interesting one to look at as it's where
we have 6.0.0a and where we're currently hacking on new unbundling. So,
http://pkgs.fedoraproject.org/cgit/owncloud.git/tree/owncloud.spec is
our current 'state of the art', more or less.

> > I've also been taking some swings at the Doctrine/DBAL stuff which might
> > interest you - I managed to map almost all the OwnCloud patches to
> > upstream commits,
> [snip]
> 
> Thanks a lot for the detailed information, I may bounce your initial
> message directly to the list if someone is willing to look at it: I’m
> not sure that I wish to maintain a patched version of Doctrine/DBAL
> right now, but I really appreciate your follow up upstream so we can all
> benefit of the improvements.
> 
> For the record (as already told in IRC), the owncloud Debian package
> currently ships an embedded patched copy of Doctrine/DBAL, since using
> the php-doctrine-dbal package ends up in failing to upgrade from ownCloud 5.

Right now we have OC 6.0.0a in Rawhide depending on the system copy of
DBAL 2.3.4, and yes, at first I found exactly the same thing! (No-one's
supposed to run anything close to production on Rawhide, so it's okay
when we do this kind of thing). A couple of days ago I backported enough
of the OC DBAL patches to our DBAL package that at least a MySQL upgrade
(mine) worked. Upstream has now landed almost all the OC patches on the
2.4 branch, so getting a DBAL 2.4 that should be good for OC is merely a
matter of building 2.4.1 with cherry-picked patches, and hoping the
2.3/2.4 diff doesn't matter: according to
https://github.com/doctrine/dbal/blob/2.4/UPGRADE , the only thing
that's backwards incompatible between 2.3 and 2.4 is "custom classes
that implement the constraint interface"; I'm not sure whether OC has
any of those, I meant to have a look.

> > Gregor (the owner of Fedora's owncloud package) is currently working on
> > packaging php-opencloud, and I'm going to take a look at irodsphp
> > tomorrow. And to think I do this for *fun*...=)
> 
> If it’s of any help, we already took care of those in Debian:
>   - http://packages.qa.debian.org/p/php-opencloud.html
>   - http://packages.qa.debian.org/p/php-irods.html
> (those pages should link to any relevant material for developers, but
> feel free to ask for more information if needed).

In the end I dashed off irods last night, and yeah, the Debian package
was a big help, I followed the approach of ripping out a lot of the crap
in the tarball and also stole the description wholesale. =) thanks!
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net