[Pkg-pascal-devel] Please review ddrescueview packaging

[Graham Inggs]

On 16 May 2015 at 20:35, Paul Gevers <elbrus at debian.org> wrote:
> Have you submitted your (rather small) manpage upstream?
> Have you submitted your desktop file upstream?

Not explicitly.  I did point upstream to the git on Alioth, but I will
mention those files.

> Please comment your lintian override.

OK, I should confirm exactly where it comes from (I guess somewhere in
lcl) and make the same note in doublecmd, as the same
spelling-error-in-binary occurs there too.

> How did you create the xpm? I assume you created it from the ico, can't
> you do that at build time instead?

I converted in GIMP, but I guess it could be done from the command
line with imagemagick, or similar.
I don't believe it is something that needs to be done with every build
as the icon shouldn't change all that often.
How about a manual target in debian/rules?

> Isn't the "Feature" list on the upstream website worth mentioning in the
> description of the package?

Good idea, thanks.

> Have you considered asking upstream to provide a gz/bz2/xz (and signed)
> tar-ball?

I will do that.

> When I use uscan to download the upstream zip I get a gz file,
> while you checked in a xz file. Shouldn't we make sure we always get the
> same (xz) compression?

The git-orig-source target in debian/rules will get you xz compression.