Bug#596025: dh-make-perl: The wrong version can be used when building

[Andrew Ruthven]

Package: dh-make-perl
Version: 0.70-1
Severity: normal
Tags: patch

Hi,

dh-make-perl looks in a number of places, including Makefile.PL to work out
the version of the package that is being built.  However the regex is a
bit general and can match fields like:

  MIN_PERL_VERSION

Which might be used in preference to the actual version of package being
built..

The regex is on line 401 of:

  /usr/share/perl5/DhMakePerl/Command/Packaging.pm

Attached is a patch which resolves this issue.

Cheers!

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-vserver-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_NZ.UTF-8, LC_CTYPE=POSIX (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages dh-make-perl depends on:
ii  debhelper                     8.0.0      helper programs for debian/rules
ii  dpkg-dev                      1.15.8.4   Debian package development tools
ii  fakeroot                      1.14.4-1   Gives a fake root environment
ii  libapt-pkg-perl               0.1.24     Perl interface to libapt-pkg
ii  libarray-unique-perl          0.08-1     Tie-able array that allows only un
ii  libclass-accessor-perl        0.34-1     Perl module that automatically gen
ii  libdpkg-perl                  1.15.8.4   Dpkg perl modules
ii  libemail-date-format-perl     1.002-1    Module to generate RFC-2822-valid 
ii  liblist-moreutils-perl        0.25~02-1  Perl module with additional list f
ii  libmodule-corelist-perl       2.36-1     module to determine modules shippe
ii  libmodule-depends-perl        0.14-3     identify the dependencies of a dis
ii  libparse-debcontrol-perl      2.005-2    Easy OO parsing of Debian control-
ii  libparse-debianchangelog-perl 1.1.1-2.1  parse Debian changelogs and output
ii  libtie-ixhash-perl            1.21-2     ordered associative arrays for Per
ii  libwww-mechanize-perl         1.64-1     module to automate interaction wit
ii  libyaml-perl                  0.71-1     YAML Ain't Markup Language
ii  make                          3.81-8     An utility for Directing compilati
ii  perl                          5.10.1-14  Larry Wall's Practical Extraction 
ii  perl-modules [libmodule-corel 5.10.1-14  Core Perl modules

Versions of packages dh-make-perl recommends:
ii  apt-file                      2.4.0      search for files within Debian pac

dh-make-perl suggests no packages.

-- no debconf information
-------------- next part --------------
--- Packaging.pm.orig	2010-09-08 12:55:04.000000000 +1200
+++ Packaging.pm	2010-09-08 12:55:25.000000000 +1200
@@ -398,7 +398,7 @@
         $ver = $self->cfg->version;
 
     }
-    elsif ( $file =~ /([\'\"]?)VERSION\1\s*(=>|,)\s*([\'\"]?)(\S+)\3/s ) {
+    elsif ( $file =~ /([\'\"]?)(?<!_)VERSION\1\s*(=>|,)\s*([\'\"]?)(\S+)\3/s ) {
 
         # Regular MakeMaker
         $ver = $4;