Bug#596025: dh-make-perl: The wrong version can be used when building

[Salvatore Bonaccorso]

Hi Andrew

On Wed, Sep 08, 2010 at 12:56:54PM +1200, Andrew Ruthven wrote:
> Package: dh-make-perl
> Version: 0.70-1
> Severity: normal
> Tags: patch
> 
> Hi,
> 
> dh-make-perl looks in a number of places, including Makefile.PL to work out
> the version of the package that is being built.  However the regex is a
> bit general and can match fields like:
> 
>   MIN_PERL_VERSION
> 
> Which might be used in preference to the actual version of package being
> built..
> 
> The regex is on line 401 of:
> 
>   /usr/share/perl5/DhMakePerl/Command/Packaging.pm
> 
> Attached is a patch which resolves this issue.

Indeed, if e.g. Makefile.PL is around, containing lines
	'MIN_PERL_VERSION' => 5.003_96,
	'VERSION_FROM  => 'lib/Foo/Bar.pm',
then if we reachthat version is gathered from Makefile.PL then we will
have version based on 5.003_96 ...

Thank you for your patch, covering too this cases, I will apply it to
the svn trunk.

Bests
Salvatore
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20100908/0853702a/attachment-0001.pgp>