Bug#687211: IPv6 recommends should be the preferred alternative

[Salvatore Bonaccorso]

Hi Gregor, Hi Matthias

On Tue, Sep 11, 2012 at 06:30:23PM +0200, gregor herrmann wrote:
> On Mon, 10 Sep 2012 22:53:41 +0200, Matthias Klose wrote:
> 
> > the alternatives for the build dependencies default to the ipv6 variants, while
> > the recommends default to ipv4.  this looks inconsistent. should the recommends
> > default to ipv6 too?
> 
> I guess (there are several alternatives with ipv6 involved) that
> refers to:
> 
> Build-Depends-Indep: libio-socket-inet6-perl | libio-socket-ip-perl (>= 0.11), 
> Recommends: libio-socket-ip-perl (>= 0.11) | libio-socket-inet6-perl,
> 
> In my understanding, libio-socket-ip-perl is newer, preferred by
> upstream, and supports both IPv4 and IPv6. So the Recommends makes
> more sense to me than the B-D-I.

Yes upstream has the following order in IO:Socket::SSL:

----cut---------cut---------cut---------cut---------cut---------cut-----
80     # try IO::Socket::IP or IO::Socket::INET6 for IPv6 support
81     if ( $ip6 ) {
82 
83         # if we have IO::Socket::IP >= 0.11 we will use this in preference
84         # because it can handle both IPv4 and IPv6
85         if ( eval { require IO::Socket::IP; IO::Socket::IP->VERSION(0.11); } ) {
86             @ISA = qw(IO::Socket::IP);
87             constant->import( CAN_IPV6 => "IO::Socket::IP" );
88 
89         # if we have IO::Socket::INET6 we will use this not IO::Socket::INET
90         # because it can handle both IPv4 and IPv6
91         } elsif( eval { require IO::Socket::INET6; } ) {
92             @ISA = qw(IO::Socket::INET6);
93             constant->import( CAN_IPV6 => "IO::Socket::INET6" );
94         } else {
95             $ip6 = 0;
96         }
97     }
----cut---------cut---------cut---------cut---------cut---------cut-----

So it first checks for IO::Socket::IP and then vor IO::socket::INET6
if the first one does not succeed. I would thus think it's correct to
leave libio-socket-ip-perl (>= 0.11) | libio-socket-inet6-perl.

> Not sure about the difference between build and runtime deps; those
> lines changed several lines in the recent git historiy :)
> 
> Salvatore, do you still remember the reason for c622141?
> 
> | Interchange build-dependency for libio-socket-inet6-perl
> |
> | -Build-Depends-Indep: libio-socket-ip-perl (>= 0.11) | libio-socket-inet6-perl,
> | +Build-Depends-Indep: libio-socket-inet6-perl | libio-socket-ip-perl (>= 0.11),
> 
> 
> Ah, I think libio-socket-ip-perl was too old (i.e. 0.11 not yet
> uploaded) at the time of the change?

I'm not anymore 100% sure, but yes I think you are correct. At the
time of the change I added

TODO: libio-socket-ip-perl (>= 0.11) | libio-socket-inet6-perl as B-D-I will
not work for sbuild builds.

to the changelog. This was on 2012-06-18. And in fact
libio-socket-ip-perl (0.16-1) was then uploaded on 2012-06-28. But
libio-socket-ssl-perl 0.76-1 was already uploaded by me on 2012-06-22.

At first glance it seems okay for me to now also change the
Build-Depends-Indep ordering.

Regards,
Salvatore
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20120911/1898a0c6/attachment.pgp>