buggy patch in IO::AIO

[gregor herrmann]

On Wed, 20 Apr 2016 16:01:55 +0200, Marc Lehmann wrote:

> Hi!
> I was notified that you apply buggy patches to IO::AIO in debian gnu/linux.

Hi Marc!

Thanks for your mail, and sorry for the late reply, I was mostly
offline for the past 8 days.

In general it's recommended to dicuss such questions via (the Debian
BTS or) the maintainer address; I'm cc'ing
pkg-perl-maintainers at lists.alioth.debian.org now.
 
> Specifically, the spelling.patch doesn't actually fix a warning or a bug
> in the module, but simply silences a bug somewhere else, namely the code
> that enables warnings inside IO::AIO (effectively patching the code). That
> is, the warning is not caused by IO::AIO itself, but by other code (which
> will not get fixed because the warning is silenced).

I believe that's not what spelling.patch is doing. Looking at
https://anonscm.debian.org/cgit/pkg-perl/packages/libio-aio-perl.git/tree/debian/patches/spelling.patch
I only see 2 characters changed, both in the POD to fix spelling
mistakes (occured → occurred, let's → lets).
 
> Background: in perl it is completely legal to redefine symbols, unless
> one explicitly requests aw warning for that, which IO::AIO doesn't do
> - so whatever code that is now silenced might break in weird ways for
> future releases because IO::AIO was not written to conform to any warning
> standard but it's own.

Maybe you are referring to the second patch we are currently
applying:
https://anonscm.debian.org/cgit/pkg-perl/packages/libio-aio-perl.git/tree/debian/patches/duplicate-constant.patch

This change looks harmless to me but maybe I'm wrong ...
 
> It's no issue that you didn't understand the problem, being a package
> maintainer, but I do wonder why you didn't follow debian's policy of
> sending this patch upstream for discussion? That could have quickly
> clarified the problem.

You're right that I should have forwarded the patches, sorry for
being lazy in this case.


Cheers,
gregor

-- 
 .''`.  Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: Digital Signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20160426/15de13d4/attachment.sig>