Bug#851848: dh-make-perl: Dependency resolution using Debian::AptContents fails with current Contents files in Debian archive

[Manfred Stock]

Package: dh-make-perl
Version: 0.84-2
Severity: normal
Tags: patch

Dear Maintainer,

I recently noticed that the dependency resolution does not find existing Debian
packages anymore when it is done using Debian::AptContents. One example is a
Perl distribution that uses Catalyst::Runtime, which resulted in a dependency
on libcatalyst-runtime-perl (caused by falling back to CPAN-based dependency
resolution), even though Catalyst::Runtime is part of the libcatalyst-perl
package available in Debian.

After adding some debug code to dh-make-perl and looking at Contents.cache, I
noticed that a lot of files never made it into the cache. Then I noticed that
Debian::AptContents attempts to skip the header in Contents files, which is not
contained in current Contents files in the archive anymore (which likely is a
change that became visible for Jessie during the recent point release, the main
bug regarding this seems to be #841997 [1], and there already is #842887 [2] in
dh-make-perl, which is somewhat related). This change in the Contents files
does not affect current versions of dh-make-perl, but caused a regression in
the version of dh-make-perl in Jessie. The attached patch fixed the problem for
me.

Kind regards
Manfred

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841997
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=842887

-- System Information:
Debian Release: 8.7
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.8.0-0.bpo.2-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_CH.utf8, LC_CTYPE=de_CH.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages dh-make-perl depends on:
ii  debhelper                         9.20150101+deb8u2
ii  dpkg-dev                          1.17.27
ii  fakeroot                          1.20.2-1
ii  libapt-pkg-perl                   0.1.29+b2
ii  libarray-unique-perl              0.08-1
ii  libclass-accessor-perl            0.34-1
ii  libcpan-meta-perl                 2.142690-1
ii  libdpkg-perl                      1.17.27
ii  libemail-address-perl             1.905-2
ii  libemail-date-format-perl         1.005-1
ii  libfile-which-perl                1.09-1
ii  liblist-moreutils-perl            0.33-2+b1
ii  libmodule-depends-perl            0.16-1
ii  libparse-debcontrol-perl          2.005-4
ii  libparse-debianchangelog-perl     1.2.0-1.1
ii  libsoftware-license-perl          0.103010-3
ii  libtie-ixhash-perl                1.23-1
ii  libwww-mechanize-perl             1.73-2
ii  libyaml-libyaml-perl              0.41-6
ii  libyaml-perl                      1.13-1
ii  make                              4.0-8.1
ii  perl                              5.20.2-3+deb8u6
ii  perl-modules [libcpan-meta-perl]  5.20.2-3+deb8u6

Versions of packages dh-make-perl recommends:
ii  apt-file      2.5.4
ii  git           1:2.1.4-2.1+deb8u2
ii  pristine-tar  1.33

dh-make-perl suggests no packages.

-- debconf-show failed
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Support-Contents-files-without-header.patch
Type: text/x-diff
Size: 5748 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20170119/0a2dba8f/attachment.patch>