Patch for libconfig-model-dpkg-perl to set Vcs fields for Neurodebian

[gregor herrmann]

On Tue, 17 Apr 2018 09:17:37 +0200, Andreas Tille wrote:

> the Debian Med team is helping the Neurodebian team with the Salsa
> migration.  I've added a git format-patch which I think is OK 

Thanks! Applied.

> but I was
> not able to build libconfig-model-dpkg-perl in the current state.  Some
> tests were failing.

Hm, I'll have a look, but maybe that's related to recent changes by
dod.
 
> I added another diff for a test.  However, as far as I understood that
> test first needs to run `cme fix dpkg-control` first before it succeeds
> (but my understanding of cme is pretty poor).

The test needs a bit more information :)
First a debian/control file, and then dependency informations, and
then more warnings to check, as the package you picked currently has
an ancient debian/control file. (Of course cleaning up the file before,
as you suggested, might also help. Or picking a different example.)

*some time later*

Ok, I've now taken a different package with a trivial d/control, as
we only want to check the fixup for Vcs-*.

Good. This works:

# perl -Ilib t/model_tests.t x dpkg-control neurodebian-team
# Calling run_tests with argument is deprecated
ok 1 - compiled
# Beginning dpkg-control test (t/model_tests.d/dpkg-control-test-conf.pl)
# dpkg-control uses Dpkg::Control model on file control
# Beginning subtest dpkg-control neurodebian-team
ok 2 - Copied dpkg-control example neurodebian-team
Reading package lists... Done
Building dependency tree       
Reading state information... Done
ok 3 - Read configuration and created instance with init() method with warning check 
ok 4 - apply_fixes called
# dump_warnings parameter is DEPRECATED
ok 5 - Ran dump_tree
ok 6 - Dumped dpkg-control config tree in full mode
# dump_warnings parameter is DEPRECATED
ok 7 - Ran dump_tree
ok 8 - Dumped dpkg-control config tree in custom mode
ok 9 - first check 'source Vcs-Browser' value
ok 10 - first check 'source Vcs-Git' value
ok 11 - dpkg-control write back done
ok 12 - Created instance dpkg-control-test-neurodebian-team-w
# dump_warnings parameter is DEPRECATED
ok 13 - Ran dump_tree
ok 14 - Dumped second dpkg-control config tree in custom mode
ok 15 - compare original dpkg-control custom data with 2nd instance custom data
ok 16 - check that original dpkg-control file was not clobbered
# End of subtest dpkg-control neurodebian-team
# End of dpkg-control test
ok 17 - test memory cycle
1..17
writing back cache file

Commited and pushed.

> I hope this preparation will simplify your highly regarded work a bit.

It did, thanks!


The other test failures are still there, but I'm quite sure that they
are unrelated. All of them have

#  category was 'User'
#           not 'Tree.Element.Value'

which looks like a change in Config::Model or something?


And .... while trying to push I get a conflict, and looking on IRC
that dod has pushed something.


Dominique: btw, I added some changes to gregoa/nomorealioth for the
Vcs-x fields (where x != Git and Browser). Please take a look if you
like the idea and implementation.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Paco De Lucia, Al Di Meola, John Mc Laughlin: Midsummer Night
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-perl-maintainers/attachments/20180417/4c9c7a4e/attachment.sig>