Bug#958749: libconfig-model-dpkg-perl: Parsing of wrapped long patch subjects incorrect

[Ryan Pavlik]

Package: libconfig-model-dpkg-perl
Version: 2.132~bpo10+1
Severity: normal
Tags: upstream

Dear Maintainer,

I have packages with patches maintained using gbp-pq, which wraps long
first lines of commits, indenting the subsequent line with a single space,
using that full (wrapped) line as the "Subject:".

When loading a package with such a patch in its series in cme edit dpkg:

- the text before the wrap is loaded as the "Synopsis" field, and the
  wrapped text (as well as some? following lines) is in "Subject".
- Upon editing the metadata (e.g. adding Forwarded: not-needed) and saving again,
  the second half of the subject line is now un-indented and placed among the other headers
  (see attached before.patch and after.patch)

I would expect the subject to be persisted unmodified if I don't modify it - perhaps only
adjusting wrap point or indentation.

Thank you,

Ryan Pavlik

-- System Information:
Debian Release: 10.3
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-debug'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.4.0-0.bpo.4-amd64 (SMP w/16 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libconfig-model-dpkg-perl depends on:
ii  debhelper                          12.9~bpo10+1
ii  libapt-pkg-perl                    0.1.34+b1
ii  libarray-intspan-perl              2.003-1
ii  libconfig-model-backend-yaml-perl  2.133-2
ii  libconfig-model-perl               2.133-1
ii  libexporter-lite-perl              0.08-1
ii  liblog-log4perl-perl               1.49-1
ii  libmouse-perl                      2.5.6-1+b1
ii  libparse-recdescent-perl           1.967015+dfsg-2
ii  libsoftware-licensemoreutils-perl  1.004-1
ii  libsort-versions-perl              1.62-1
ii  libtext-autoformat-perl            1.740000-2
ii  libtext-levenshtein-damerau-perl   0.41-1
ii  liburi-perl                        1.76-1
ii  libwww-perl                        6.36-2
ii  libyaml-libyaml-perl               0.76+repack-1
ii  licensecheck                       3.0.46-1~bpo10+1
ii  lintian                            2.65.0~bpo10+1
ii  perl [libmodule-corelist-perl]     5.28.1-6

Versions of packages libconfig-model-dpkg-perl recommends:
ii  libconfig-model-tkui-perl  1.369-2

libconfig-model-dpkg-perl suggests no packages.

-- no debconf information
-------------- next part --------------
Subject: pretend this is a long subject
 that got wrapped by gbp-pq
Last-Update: 2020-04-24
Date: Thu, 9 Apr 2020 17:57:07 -0500

Not sure what's going on, this looks
constexpr to me. Raised issue in upstream instead of
forwarding this workaround-resembling patch.
---
 src/xrt/auxiliary/tracking/t_tracker_psmv_fusion.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/xrt/auxiliary/tracking/t_tracker_psmv_fusion.cpp b/src/xrt/auxiliary/tracking/t_tracker_psmv_fusion.cpp
index 191d6ea..de32c83 100644
--- a/src/xrt/auxiliary/tracking/t_tracker_psmv_fusion.cpp
+++ b/src/xrt/auxiliary/tracking/t_tracker_psmv_fusion.cpp
@@ -148,7 +148,7 @@ namespace {
 			reset_filter_and_imu();
 		}
 		// 7200 deg/sec
-		constexpr double max_rad_per_sec = 20 * EIGEN_PI * 2;
+		double max_rad_per_sec = 20 * EIGEN_PI * 2;
 		if (filter_state.angularVelocity().squaredNorm() >
 		    max_rad_per_sec * max_rad_per_sec) {
 			fprintf(stderr,
-------------- next part --------------
Subject: pretend this is a long subject
Forwarded: not-needed
Last-Update: 2020-04-24
that got wrapped by gbp-pq
Date: Thu, 9 Apr 2020 17:57:07 -0500

Not sure what's going on, this looks
constexpr to me. Raised issue in upstream instead of
forwarding this workaround-resembling patch.
---
 src/xrt/auxiliary/tracking/t_tracker_psmv_fusion.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/xrt/auxiliary/tracking/t_tracker_psmv_fusion.cpp b/src/xrt/auxiliary/tracking/t_tracker_psmv_fusion.cpp
index 191d6ea..de32c83 100644
--- a/src/xrt/auxiliary/tracking/t_tracker_psmv_fusion.cpp
+++ b/src/xrt/auxiliary/tracking/t_tracker_psmv_fusion.cpp
@@ -148,7 +148,7 @@ namespace {
 			reset_filter_and_imu();
 		}
 		// 7200 deg/sec
-		constexpr double max_rad_per_sec = 20 * EIGEN_PI * 2;
+		double max_rad_per_sec = 20 * EIGEN_PI * 2;
 		if (filter_state.angularVelocity().squaredNorm() >
 		    max_rad_per_sec * max_rad_per_sec) {
 			fprintf(stderr,