Bug#971368: libfcgi-perl: missing source for FCGI_COMMON_CHECKS

[Helmut Grohne]

Source: libfcgi-perl
Version: 0.79-1
Severity: serious
Justification: missing source

I've looked into libfcgi-perl and noticed that the macro
FCGI_COMMON_CHECKS used in configure.in misses source code in the
libfcgi-perl package. I've looked in the archive and it seems that there
is another copy of this macro in another package that might do here:
https://sources.debian.org/src/libfcgi/2.4.0-10/acinclude.m4/?hl=3#L3

However, libfcgi-perl does not depend on that package in anyway, so it
definitely doesn't use it and it also does not prevent removal of
libfcgi, which is required for honouring DFSG (if that copy is indeed
the relevant source). Therefore, a bug of severity serious is
appropriate in my opinion.

A simple way out of this mess would be adding it to the debian
directory. That's still not nice as that prevents running autoreconf and
that prevents us from using dh_auto_configure, but it solves the rc-ness
part.

Another solution could be adding the macro to the libfcgi-dev binary
package and adding it as an (unused) build dependency. Doing so would
ensure that the source code for configure is available in the archive.

A better solution would likely be solving #841078 although doing so is
more involved.

Helmut