Bug#1001173: Moo: Should use Depends for libclass-xsaccessor-perl (instead of Recoomends)

[Felix Lechner]

Package: libmoo-perl

Hi,

Moo performs faster when Class::XSAccessor is available [1] but
libmoo-perl only Recommends it. More important, Moo's behavior changes
when Class::XSAccessor is installed. [1]  For consistency as well as
performance, Moo should probably Depend on libclass-xsaccessor-perl.

While a new, hard prerequisite may cause some programs using Moo to
fail unexpectedly, they would at least do so consistently. It would
eliminate a transient class of bugs that depends on whether
Class::XSAccessor is present on a reporter's system—something that can
be hard to pin down when the installable is only recommended.

Lintian was affected in several ways. [2][3][4][5][6]

Sorry to report the suggestion with a two-year delay. Thank you!

Kind regards
Felix Lechner

[1] https://metacpan.org/pod/Moo#MOO-AND-CLASS::XSACCESSOR
[2] https://salsa.debian.org/lintian/lintian/commit/b951f0d4d83fa76286d1f4bd5836cf256038f31c
[3] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943724#30
[4] https://salsa.debian.org/lintian/lintian/commit/f4c5659353198014d56810bec72225dda1dd21c8
[5] https://salsa.debian.org/lintian/lintian/commit/29a4d4dc6967f959f7c167a8b09e35c3610a3812
[6] https://salsa.debian.org/lintian/lintian/commit/15ae1403b8f455d4672990492cdb7a14929e40dc