Bug#1001173: Moo: Should use Depends for libclass-xsaccessor-perl (instead of Recoomends)

[intrigeri]

Hi,

Felix Lechner (2021-12-05):
> Moo performs faster when Class::XSAccessor is available [1] but
> libmoo-perl only Recommends it. More important, Moo's behavior changes
> when Class::XSAccessor is installed. [1]  For consistency as well as
> performance, Moo should probably Depend on libclass-xsaccessor-perl.
>
> While a new, hard prerequisite may cause some programs using Moo to
> fail unexpectedly, they would at least do so consistently. It would
> eliminate a transient class of bugs that depends on whether
> Class::XSAccessor is present on a reporter's system—something that can
> be hard to pin down when the installable is only recommended.

I agree with your reasoning.

I'm 90% convinced we should do this but I'd first like to understand
why upstream chose to only recommend Class::XSAccessor: their
reasoning might make sense for us too :)

Would you mind asking upstream about this?

Thanks in advance!