Bug#971784: libconfig-model-dpkg-perl: cme should not warn on "unknown dh-sequence-nodejs package"

[gregor herrmann]

On Sun, 11 Oct 2020 16:59:09 +0200, Dominique Dumont wrote:

> On mercredi 7 octobre 2020 16:49:30 CEST you wrote:
> > Maybe adding a regexp to
> > 
> >         if ( @res == 0 and not $virtual_hash{$pkg}) {
> > 
> > would be enough? Like (untested pseudo-code)
> > 
> >     … and $pkg =! /^dh-sequence-.+/
> 
> That's a good start.
> 
> But %virtual_hash is used in 2 other places.
> 
> I'd suggest:
> - create a method _is_virtual that uses %virtual_hash and the regexp you 
> suggested
> - use this method instead of directly reading $virtual_hash($pkg_name)
> 
> gregoa, do you want to try fixing this bug ?

After a slight delay *cough*:
Yes, I want to try :)

I just pushed the changes as proposed, looking forward to
reviews/feedback.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Leonard Cohen: Show Me The Place
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-perl-maintainers/attachments/20210117/7ca1a627/attachment.sig>