Bug#971784: libconfig-model-dpkg-perl: cme should not warn on "unknown dh-sequence-nodejs package"
Dominique Dumont
dod at debian.org
Tue Jan 19 09:11:42 GMT 2021
On Sunday, 17 January 2021 19:57:39 CET you wrote:
> I just pushed the changes as proposed, looking forward to
> reviews/feedback.
Thanks for the patch (with test and doc ! :-) )
There's no issue, but 2 comments for the new _is_virtual function:
- in cme dpkg, I tend to use function signatures for new function instead of
Perl'd old way of passing parameters. I know that I should convert all
functions to signatures, but I've not taken the time to do it...
- the regexp /^dh-sequence-.+/ also matches dh-sequence-!@#. Given the list of
dh-sequence-* package names removed from the code, I'd suggest a more
restrictive regexp like /^dh-sequence-[a-z0-9-]+$/
All the best
More information about the pkg-perl-maintainers
mailing list