Bug#971784: libconfig-model-dpkg-perl: cme should not warn on "unknown dh-sequence-nodejs package"

[gregor herrmann]

On Tue, 19 Jan 2021 10:11:42 +0100, Dominique Dumont wrote:

> On Sunday, 17 January 2021 19:57:39 CET you wrote:
> > I just pushed the changes as proposed, looking forward to
> > reviews/feedback.
> Thanks for the patch (with test and doc ! :-) )

Thanks for the review!
 
> There's no issue, but 2 comments for the new _is_virtual function:
> 
> - in cme dpkg, I tend to use function signatures for new function instead of 
> Perl'd old way of passing parameters. I know that I should convert all 
> functions to signatures, but I've not taken the time to do it...

Ah, good idea. Changed.
 
> - the regexp /^dh-sequence-.+/ also matches dh-sequence-!@#. Given the list of 
> dh-sequence-* package names removed from the code, I'd suggest a more 
> restrictive regexp like /^dh-sequence-[a-z0-9-]+$/

Right, I had the feeling that this regexp is a bit broad; thanks for
the suggestion, committed.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Various Artists: Sweet Sixteen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-perl-maintainers/attachments/20210124/3af32a4c/attachment.sig>