Bug#1008939: use.t: allow empty lines in debian/tests/pkg-perl/use-name? (also use-whitelist)

[Niko Tyni]

On Mon, Apr 04, 2022 at 08:07:37PM +0200, gregor herrmann wrote:
> Package: pkg-perl-autopkgtest
> Version: 0.66
> Severity: important
> Tags: patch
> X-Debbugs-Cc: ntyni at debian.org

> This is a kind of followup for #1008267:

>   not ok 5 -  /usr/bin/perl -w -M"" -e 1 2>&1 exited successfully
>   not ok 6 -  /usr/bin/perl -w -M"" -e 1 2>&1 produced no (non-whitelisted) output

>   % cat debian/tests/pkg-perl/use-name
>   # Chart.pm is only documentation. Let's check Chart::Base.
>   Chart::Base
> 
>   # other options
>   # Chart::Bars
>   # Chart::Composite

> For now I've removed the empty line in libchart-perl's
> debian/tests/pkg-perl/use-name but as this has potential for breaking
> other packages' autopkgtests and is also counter-intuitive, I suggest
> we accept and ignore empty lines in debian/tests/pkg-perl/use-name
> (and also debian/tests/pkg-perl/use-whitelist).

Yeah, absolutely. Thanks for noticing this.

> Proposed patch:
> 
> #v+
> - --- /usr/share/pkg-perl-autopkgtest/runtime-deps.d/use.t.packaged       2022-04-04 17:48:42.204873999 +0000
> +++ /usr/share/pkg-perl-autopkgtest/runtime-deps.d/use.t        2022-04-04 17:51:26.125604484 +0000
> @@ -39,7 +39,7 @@
>              or BAIL_OUT("$conffile exists but can't be read");
>          while (<M>) {
>              chomp;
> - -            next if /^\s*#/;
> +            next if /^\s*(#|$)/;
>              push @ret, $_;
>          }
>          close M;
> #v-

I'd phrase this as an additional 'next if !/\S/;' myself but whatever
works is fine by me :)
-- 
Niko