Bug#1008939: use.t: allow empty lines in debian/tests/pkg-perl/use-name? (also use-whitelist)

[gregor herrmann]

On Fri, 08 Apr 2022 19:57:39 +0300, Niko Tyni wrote:

> > For now I've removed the empty line in libchart-perl's
> > debian/tests/pkg-perl/use-name but as this has potential for breaking
> > other packages' autopkgtests and is also counter-intuitive, I suggest
> > we accept and ignore empty lines in debian/tests/pkg-perl/use-name
> > (and also debian/tests/pkg-perl/use-whitelist).
> Yeah, absolutely. Thanks for noticing this.

Great, thanks for the review and the confirmation.
 
> > Proposed patch:
> > 
> > #v+
> > - --- /usr/share/pkg-perl-autopkgtest/runtime-deps.d/use.t.packaged       2022-04-04 17:48:42.204873999 +0000
> > +++ /usr/share/pkg-perl-autopkgtest/runtime-deps.d/use.t        2022-04-04 17:51:26.125604484 +0000
> > @@ -39,7 +39,7 @@
> >              or BAIL_OUT("$conffile exists but can't be read");
> >          while (<M>) {
> >              chomp;
> > - -            next if /^\s*#/;
> > +            next if /^\s*(#|$)/;
> >              push @ret, $_;
> >          }
> >          close M;
> > #v-
> 
> I'd phrase this as an additional 'next if !/\S/;' myself but whatever
> works is fine by me :)

I took your version, as two lines might be easier to read; thanks.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-perl-maintainers/attachments/20220408/6a12f517/attachment.sig>