Bug#1060911: darktable: remove dpkg-parsechangelog usage to please lintian

Tino Mettler tino.mettler+debbugs at tikei.de
Tue Jan 16 12:08:33 GMT 2024


Package: darktable
Version: 4.6.0-1
Severity: normal
Tags: patch

Hi David,

this patch
- removes dpkg-parsechangelog usage
- removes get-orig-source, which you told me is not used anymore
- uses pkg-info.mk to get the upstream version for version.cmake

Regards,
Tino

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.6.10 (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_UNSIGNED_MODULE
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages darktable depends on:
ii  libavif16                1.0.3-1
ii  libc6                    2.37-7
ii  libcairo2                1.16.0-7
ii  libcolord-gtk1           0.3.0-4
ii  libcolord2               1.4.6-2.2
ii  libcups2                 2.4.2-5
ii  libcurl3-gnutls          8.2.1-2
ii  libexiv2-27              0.27.6-1
ii  libgcc-s1                13.2.0-3
ii  libgdk-pixbuf-2.0-0      2.42.10+dfsg-1+b1
ii  libglib2.0-0             2.77.3-1
ii  libgomp1                 13.2.0-3
ii  libgphoto2-6             2.5.30-1
ii  libgphoto2-port12        2.5.30-1
ii  libgraphicsmagick-q16-3  1.4+really1.3.41-1
ii  libgtk-3-0               3.24.38-4
ii  libheif1                 1.17.1-1+b1
ii  libicu72                 72.1-3
ii  libimath-3-1-29          3.1.9-3
ii  libjpeg62-turbo          1:2.1.5-2
ii  libjson-glib-1.0-0       1.6.6-1
ii  libjxl0.7                0.7.0-10
ii  liblcms2-2               2.14-2
ii  liblensfun1              0.3.4-1
ii  liblua5.4-0              5.4.6-1
ii  libopenexr-3-1-30        3.1.5-5.1
ii  libopenjp2-7             2.5.0-2
ii  libosmgpsmap-1.0-1       1.2.0-2
ii  libpango-1.0-0           1.51.0+ds-2
ii  libpangocairo-1.0-0      1.51.0+ds-2
ii  libpng16-16              1.6.40-1
ii  libportmidi0             1:217-6.1
ii  libpugixml1v5            1.13-0.2
ii  libraw23                 0.21.1-7
ii  librsvg2-2               2.54.7+dfsg-2
ii  libsdl2-2.0-0            2.28.3+dfsg-1
ii  libsecret-1-0            0.21.0-1
ii  libsqlite3-0             3.43.0-1
ii  libstdc++6               13.2.0-3
ii  libtiff6                 4.5.1+git230720-1
ii  libwebp7                 1.3.2-0.3
ii  libwebpmux3              1.3.2-0.3
ii  libx11-6                 2:1.8.6-1
ii  libxml2                  2.9.14+dfsg-1.3
ii  libxrandr2               2:1.5.2-2+b1
ii  zlib1g                   1:1.2.13.dfsg-3

darktable recommends no packages.

darktable suggests no packages.

-- debconf-show failed
-------------- next part --------------
diff --git a/debian/rules b/debian/rules
index 24268394a..d661592a6 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,10 +1,7 @@
 #!/usr/bin/make -f
 # -*- makefile -*-
 
-SOURCEPKG=$(shell dpkg-parsechangelog | sed  -n 's/^Source: \(.*\)/\1/p')
-UPSTREAM=$(shell dpkg-parsechangelog |  sed -n 's/^Version: \(.*\)-[^-]*/\1/p')
-SHA1=$(lastword $(subst ~g, ,$(UPSTREAM)))
-ORIG=${SOURCEPKG}_${UPSTREAM}.orig.tar.gz
+include /usr/share/dpkg/pkg-info.mk
 
 export CONFIG_SHELL=/bin/bash
 
@@ -25,10 +22,7 @@ override_dh_auto_configure: cmake/version.cmake
 describe-current-version:
 	git describe --tags upstream | sed 's,^release-,,;s,-,+,;s,-,~,;'
 
-get-orig-source:
-	git archive --format=tar $(SHA1) | gzip -9 > ../$(ORIG)
-
-.PHONY: describe-current-version git-orig-source
+.PHONY: describe-current-version
 
 cmake/version.cmake:
-	echo "set(PROJECT_VERSION \"${UPSTREAM}\")" > $@
+	echo "set(PROJECT_VERSION \"${DEB_VERSION_UPSTREAM}\")" > $@


More information about the Pkg-phototools-devel mailing list