[pkg-php-pear] Bug#656960: [RFR] - Multiple (4) PEAR packages needed by PHPUnit - Was: [RFR] - PHP_Timer (Needed by phpunit)

[Thomas Goirand]

On 03/27/2012 12:59 AM, Luis Uribe wrote:
> [4] http://mentors.debian.net/debian/pool/main/p/php-file-iterator/php-file-iterator_1.3.1-1.dsc

Hi,

I had a look to that one. Your Git repository contains the branches:

  origin/master
  origin/old-master
  origin/old-upstream
  origin/upstream

I (and I believe, others in the PEAR team) usually use:
- debian-sid
- upstream-sid
- debian-wheezy
- upstream-wheezy
- debian-squeeze
- upstream-squeeze

(and eventually some more branches for backports...)

Would you be able to do that? Also, I often add a debian/gbp.conf with
the following:

[DEFAULT]
upstream-branch = upstream-sid
debian-branch = debian-sid

[git-buildpackage]
export-dir = ../build-area/

so that you don't have to define the branches on the command line which
is quite boring. It'd be great if you could follow that scheme, it makes
the life of everyone a way more easy.

Many of your files (for example, debian/control, debian/copyright,
debian/rules, but their might be others) are missing a \n (eg: new line)
at the end of file. It'd be great if you could fix it, it's really
annoying when I do "cat debian/control" and then I have my shell prompt
displayed in an ugly way.

I've seen that your debian/rules, after override_dh_install, is removing
files manually. Shouldn't the pkg-php-tools do that work instead of you
manually? Is this really needed? If so, then maybe we should consider
changing pkg-php-tools so that it can handle channels in a better way
(it seems to be a trivial change to me). Note that I'm writing here in a
very open mind way, with the will to make things better and easier (and
as a team).

Cheers,

Thomas