[pkg-php-pear] php-psr-log package
"David Prévot"
david at tilapin.org
Sun Feb 9 23:21:05 UTC 2014
Hi François-Régis,
> Great, it works, I've the 1.0.0 upstream version and it build with
> debuild, http://anonscm.debian.org/gitweb/?p=pkg-php/php-psr-log.git
> uptodate.
Great, thats a way better basis.
Here are some more precise comments (you may have good reason not to
follow all of them, but Id prefer if youd explain why):
- control:
+ Please set Debian PHP PEAR Maintainers
<pkg-php-pear at lists.alioth.debian.org> as Maintainer and yourself as
Uploaders (following the team usual way to do it).
+ Please use debhelper (>= 9) (without .0.0) as Build-Depends as
advised in debhelper(7).
+ Why did you setup a different Homepage than the one suggested in the
initial RFP?
+ You may prefer to patch composer.json instead of declaring php5 |
php5-cli as Depends until #737752 gets fixed.
+ Please use the ${phpcomposer:
stuff at least for Depends and Suggests
as advised on /usr/share/doc/pkg-php-tools/README.Composer (I know
theyll be void currently, but that may evolve in the future).
- copyright:
+ Please document Upstream-Contact.
+ Please use the same license as upstream for the Debian packaging.
- Please dont ship the Test directory in the binary package.
- Please consider running the tests during the build, and provide a DEP-8
compliant setup.
> But gbp buildpackage hangs up with
> dpkg-source: error: aborting due to unexpected upstream changes, see
> /tmp/php-psr-log_1.0.0-1.diff.ErMiOk
I cant reproduce the issue (it builds fine for me), please send the
relevant diff or (paste it on paste.d.n) if needed.
Regards
David
More information about the pkg-php-pear
mailing list