[pkg-php-pear] php-psr-log package

[François-Régis]

Hi David,

Le 10/02/2014 00:21, "David Prévot" a écrit :
> Here are some more precise comments (you may have good reason not to
> follow all of them, but I’d prefer if you’d explain why):
> - control:
>  + Please set “Debian PHP PEAR Maintainers
> <pkg-php-pear at lists.alioth.debian.org>” as Maintainer and yourself as
> Uploaders (following the team usual way to do it).

done

>  + Please use debhelper (>= 9) (without “.0.0”) as Build-Depends as
> advised in debhelper(7).

done

>  + Why did you setup a different Homepage than the one suggested in the
> initial RFP?

done

>  + You may prefer to patch composer.json instead of declaring “php5 |
> php5-cli” as Depends until #737752 gets fixed.

done althought debuild complains about source being modified. It seems
to apply the patch before comparing to original source archive. gbp
builpackage works fine...

>  + Please use the ${phpcomposer:… stuff at least for Depends and Suggests
> as advised on /usr/share/doc/pkg-php-tools/README.Composer (I know
> they’ll be void currently, but that may evolve in the future).

done

> - copyright:
>  + Please document Upstream-Contact.

Done (from who has start and more commited on github)

>  + Please use the same license as upstream for the Debian packaging.

done

> - Please don’t ship the Test directory in the binary package.

done

> - Please consider running the tests during the build, and provide a DEP-8
> compliant setup.

Yes I'm trying but it's more work as don't know phpunit and the
interaction whith composer semms a bit complicated. Right now I just
have 7 warnings on Cannot instantiate class
"Psr\Log\Test\LoggerInterfaceTest". I think it's related to autoloader
but I can instantiate the class with php-cli.

I'm try to understand what you have done in opencloud and apply the same
method, I think I'll have more precise questions in a while...

> 
>> But gbp buildpackage hangs up with
>> dpkg-source: error: aborting due to unexpected upstream changes, see
>> /tmp/php-psr-log_1.0.0-1.diff.ErMiOk
> 
> I can’t reproduce the issue (it builds fine for me), please send the
> relevant diff or (paste it on paste.d.n) if needed.

It was a mess between debuild build area and gbp build area (gbp found
orig.ta.gz in ../build-area)

Thanks for your comments,

Cheers,
-- 
François-Régis