[pkg-php-pear] php-psr-log package

[François-Régis]

Hi David,

Sorry for the previous personal post...

Le 11/02/2014 00:02, David Prévot a écrit :
> Thanks for your quick update. I don’t know what went wrong with the Git
> repository, but all branches (and your tag) were changed (thus needed a
> forced update for all of them).

Sorry I've re-make the repository, (don't ever thought anybody could
follow it), I won't.

>>>  + Please use the ${phpcomposer:… stuff at least for Depends and Suggests
>>> as advised on /usr/share/doc/pkg-php-tools/README.Composer (I know
>>> they’ll be void currently, but that may evolve in the future).
> 
>> done
> 
> You initially used ${phpcomposer:description}, and then you reverted
> this by hardcoding a copy of the composer.json description into control,
> why? One way or the other (e.g., via another composer.json patch),
> please remove the initial capital:

Main reason was that dput shows "${phpcomposer:description}" on package
page (which is not meaningfull) and more I fears that other tools may
not catch the real summary. But if not I'll revert.

> https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-synopsis

OK done

>>>  + Please use the same license as upstream for the Debian packaging.
> 
>> done
> 
> AFAICT, the debian/* license is still GPL-2+ while upstream uses Expat.

Probably mess a commit... Done

>>> - Please don’t ship the Test directory in the binary package.
> 
>> done
> 
> Nice, never thought of calling dh directly with -X.

Was idea from Raphaël Hertzog on another package, not mine at all...

> 
>> Yes I'm trying but it's more work as don't know phpunit and the
>> interaction whith composer semms a bit complicated. Right now I just
>> have 7 warnings on Cannot instantiate class
>> "Psr\Log\Test\LoggerInterfaceTest". I think it's related to autoloader
>> but I can instantiate the class with php-cli.
> 
> FWIW, I gave it a quick shot yesterday and didn’t find an easy
> workaround either (that doesn’t mean it shouldn’t be fixed, but I will
> not consider it as a blocker for the initial upload).
> 
>> I'm try to understand what you have done in opencloud and apply the same
>> method, I think I'll have more precise questions in a while...
> 
> And I’ll try to share the very little bit of experience I have on the
> matter if possible.

I'm very interested in making that working, already dived in phpunit
(and phpcomposer) docs.

Cheers,

-- 
François-Régis



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 880 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20140211/ec68a704/attachment.sig>