[pkg-php-pear] php-psr-log package

[David Prévot]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi François-Régis,

Le 10/02/2014 09:07, François-Régis a écrit :
> Le 10/02/2014 00:21, "David Prévot" a écrit :
>> Here are some more precise comments

Thanks for your quick update. I don’t know what went wrong with the Git
repository, but all branches (and your tag) were changed (thus needed a
forced update for all of them).

>>  + Please use the ${phpcomposer:… stuff at least for Depends and Suggests
>> as advised on /usr/share/doc/pkg-php-tools/README.Composer (I know
>> they’ll be void currently, but that may evolve in the future).
> 
> done

You initially used ${phpcomposer:description}, and then you reverted
this by hardcoding a copy of the composer.json description into control,
why? One way or the other (e.g., via another composer.json patch),
please remove the initial capital:

https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-synopsis

>>  + Please use the same license as upstream for the Debian packaging.
> 
> done

AFAICT, the debian/* license is still GPL-2+ while upstream uses Expat.

>> - Please don’t ship the Test directory in the binary package.
> 
> done

Nice, never thought of calling dh directly with -X.

> Yes I'm trying but it's more work as don't know phpunit and the
> interaction whith composer semms a bit complicated. Right now I just
> have 7 warnings on Cannot instantiate class
> "Psr\Log\Test\LoggerInterfaceTest". I think it's related to autoloader
> but I can instantiate the class with php-cli.

FWIW, I gave it a quick shot yesterday and didn’t find an easy
workaround either (that doesn’t mean it shouldn’t be fixed, but I will
not consider it as a blocker for the initial upload).

> I'm try to understand what you have done in opencloud and apply the same
> method, I think I'll have more precise questions in a while...

And I’ll try to share the very little bit of experience I have on the
matter if possible.

Regards

David


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCAAGBQJS+VqHAAoJEAWMHPlE9r08n0EIAKnmHRLVPVXG2wPSP9OvxmdA
Mjk+d42RBRHPz74FiiPv7UrAhCBD0/ETyNVWSXaOjO45NQPbhY1e+4hZ4wclIC8L
DDR1SFplbTaTnHAfaaflSnYLpJ89+/LFRC42cFe4RIRzIi0CPop/s2ZfM86K63zK
FekFfwRjNNAhUulcTrCyf4qMV+dklmX1fcFm1G7Wc96r2KO4HcQkLstR5b1upaEh
/8AFTUqfK9dV8/sdQ+o3tOgMtoC4mNa/zs5cLF5dLs+41nKjv1QTevzC2ckumpdV
ClIs1T4AYDNiOhxc4NfIBe/Sv/yeHfyMtRm4LbQvJJRTtPIs/e/17IlgGdLH0Ds=
=CrKE
-----END PGP SIGNATURE-----