[pkg-php-pear] Fwd: Please review php-file-find and php-file-fstab

Mathieu Parent math.parent at gmail.com
Sat Feb 15 13:58:01 UTC 2014


Hello,

[...]

About php-file-find:
- I couldn't build it with gbp when the first build failed. It seems
that your .gitignore file is the guilty (your debian branch=master
shouldn't change anything outside of the debian dir)
- your dep8 tests depend on php-file-find: IMO it should depend on "@"
instead [dep8]
- I've not uploaded it

[dep8]: http://anonscm.debian.org/gitweb/?p=autopkgtest/autopkgtest.git;a=blob_plain;f=doc/README.package-tests;hb=HEAD

I've uploaded php-file-fstab, but:
- why have you added Depends: php-pear?
- you have some lintian  warnings:
I: php-file-fstab source: vcs-field-not-canonical
http://git.debian.org/?p=pkg-php/php-file-fstab.git
http://anonscm.debian.org/gitweb/?p=pkg-php/php-file-fstab.git
I: php-file-fstab source: vcs-field-not-canonical
http://git.debian.org/git/pkg-php/php-file-fstab.git
http://anonscm.debian.org/git/pkg-php/php-file-fstab.git

Thanks for your work!

Regards

-- 
Mathieu



More information about the pkg-php-pear mailing list