[pkg-php-pear] Fwd: Please review php-file-find and php-file-fstab

[François-Régis]

Le 15/02/2014 14:58, Mathieu Parent a écrit :
> About php-file-find:
> - I couldn't build it with gbp when the first build failed. It seems
> that your .gitignore file is the guilty (your debian branch=master
> shouldn't change anything outside of the debian dir)
> - your dep8 tests depend on php-file-find: IMO it should depend on "@"
> instead [dep8]
> - I've not uploaded it

You're right it is not uploadable... I thought I'd solved some problems
(it's build with gbp at home) in fact not. My main problem comes from
the buggy tarball provided by upstream [1].

I think I need to restart from scratch using only github repo [2].

By the way, how to manage .gitignore as it's often not upstream but
usefull for packaging ?

That said, I've changed php-file-find for @

[1] http://download.pear.php.net/package/File_Find-1.3.2.tgz
[2] http://download.pear.php.net/package/File_Find-1.3.2.tgz

> I've uploaded php-file-fstab, but:

Thanks

> - why have you added Depends: php-pear?

It's added by debpear, I've report it to prachpub at gmail.com but I should
have change it, I do.

> - you have some lintian  warnings:
> I: php-file-fstab source: vcs-field-not-canonical
> http://git.debian.org/?p=pkg-php/php-file-fstab.git
> http://anonscm.debian.org/gitweb/?p=pkg-php/php-file-fstab.git
> I: php-file-fstab source: vcs-field-not-canonical
> http://git.debian.org/git/pkg-php/php-file-fstab.git
> http://anonscm.debian.org/git/pkg-php/php-file-fstab.git

debpears again and not corrected by me I do.

> Thanks for your work!

You're welcome

Cheers,

-- 
François-Régis