[pkg-php-pear] php-analog review (was: php-psr-log package)
david at tilapin.org
Sat Feb 15 19:17:51 UTC 2014
> Please, fix the php-analog Git repository: you merged again your master
> branch back into the upstreams master branch (please clean up the
> pristine-tar branch too while youre at it).
Actually, the pristine-tar branch doesnt work for me at all, please do
import the tarball fetched with uscan there.
Here is a quick review of the debian/ packaging:
Please echo .pc > ~/.gitignore instead of editing .gitignore of every
are available, please use them (even if theyre empty
Please document Upstream-Contact.
At least lib/ChromePhp.php license should be documented.
Please run dh clean prior to git add (the php-analog. prefix is
useless for the filename).
/Analog might be too much.
Please use d/examples to install examples (see dh_installexamples(1)).
cme check dpkg dies on checking it, please fix the DEP-3 header (or
alternatively, handle patches with gbp pq).
DEP-8 is about testing the installed package, not the source one.
https://github.com/jbroadway/analog/releases provides an early draft of
upstream changelog you may wish to include.
Ill review the upstream part once youve double checked d/copyright.
php-psr-log uploaded in the mean time, thanks.
More information about the pkg-php-pear