[pkg-php-pear] php-analog review

[François-Régis]

Hi David,

Sorry for this late response, I had to play a little more with git/gbp
and understand where these unwilling merges came from. I think I'm more
cumfortable now and I think what was wrong in my reading of [1].


Le 15/02/2014 20:17, "David Prévot" a écrit :
>> Please, fix the php-analog Git repository: you merged again your master
>> branch back into the upstream’s master branch (please clean up the
>> pristine-tar branch too while you’re at it).

I did a lot of mess on that repo so the easiest way for me would be to
rebuild it from scratch. Should you agree, providing I send a diff of
debian (between what is now on alioth and what will be) ?

All marked as done below is for now in my local repo, untill you tell me
the way you prefer, but as far as I know, to be real bullet-proof, this
stuff needs to be pushed...

> Actually, the pristine-tar branch doesn’t work for me at all, please do
> import the tarball fetched with uscan there.

Corrected (if new repo)

> Here is a quick review of the debian/ packaging:
> 
> Please “echo .pc > ~/.gitignore” instead of editing .gitignore of every
> package.

Done, although I found it usefull for me to specify some files from
package to package. In fact using debuild clean/dh_clean before anything
do the trick.

> [control]
> More ${phpcomposer:… are available, please use them (even if they’re empty
> now).

Done as much as I can, description in composer.json is a bit long so I
don't keep it, perhaps it would be better to patch it and send patch
upstream ?

> [copyright]
> Please document Upstream-Contact.
> At least lib/ChromePhp.php license should be documented.

Done, see below.

> [php-analog.debhelper.log]
> Please run “dh clean” prior to “git add” (the “php-analog.” prefix is
> useless for the filename).

Done, php-analog was my first try to make a real package,
php-analog.debhelper.log is a trailer.

I though it was preferable to have ${package}.install (just from what
I've seen in some packages) but I'ts obviously sharper without prefix.

> [install]
> “/Analog” might be too much.

Really too much, done.

> Please use d/examples to install examples (see dh_installexamples(1)).

Thank you for the point, done.

> [patches]
> “cme check dpkg” dies on checking it, please fix the DEP-3 header (or
> alternatively, handle patches with gbp pq).

Fixed, I've tried gbp pq but still need to investigate.

> [tests]
> DEP-8 is about testing the installed package, not the source one.

Could you point me somewhere to start ? I've read [2] but I can't deduce
any clue to achieve test on tahe installed package. From my
understanding, that would mean :
- having the tests into the binary package (what is the preferes location)
- having a trigger to run the tests during the installation (shall that
means to write specific maintener script like a postinst ?)

> [upstream/changelog]
> https://github.com/jbroadway/analog/releases provides an early draft of
> upstream changelog you may wish to include.

Done as a patch (would it be better to directly mangle the web page ?),
it's leads to modify debian/docs to *.md, but from what I've understood,
changelog should compressed. If I'm not wrong, how to achieve this ?


> I’ll review the upstream part once you’ve double checked d/copyright.

Done : examples/SplClassLoader.php is authored by Jonathan H. Wage
<jonwage at gmail.com> (https://gist.github.com/jwage/221634) and others
but has no copyright notice. What do we do with it ?

Other files are clean.

And for the review just tell me if I can restart from scratch the alioth
repo.

> php-psr-log uploaded in the mean time, thanks.

Thank's, I can now pbuild php-analog.

[1]
http://honk.sigxcpu.org/projects/git-buildpackage/manual-html/gbp.import.html#GBP.IMPORT.UPSTREAM-GIT
[2]
http://anonscm.debian.org/gitweb/?p=autopkgtest/autopkgtest.git;a=blob_plain;f=doc/README.package-tests;hb=HEAD

-- 
François-Régis