[pkg-php-pear] RFS: php-net-dnsbl and php-net-dns

[David Prévot]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Le 02/01/2014 15:32, Prach Pongpanich a écrit :
> On Fri, Jan 3, 2014 at 1:12 AM, David Prévot <david at tilapin.org> wrote:
>> Le 02/01/2014 04:38, Prach Pongpanich a écrit :

>>> [1] http://anonscm.debian.org/gitweb/?p=pkg-php/php-net-dns.git
>>
>> Please […] review the copyright:
>> the first file I opened is Net/DNS.php that is dual-licensed, please
>> document that. The copyright holder was also wrong anyway, see @copyright.
> 
> Fixed (may be),

Thanks, that was quick, but maybe too quick.

Minor: please, use only one leading space in the License stanza, more
than one leading space is only useful to force the line width as in any
other control file (e.g. lists in Description and debconf screens).
Upstream-Contact could also be documented.

Important: you seem to have properly documented the
Net_DNS-*/Net/DNS.php file, but your initial statement about most files
(Copyright: 2002-2003, Eric Kilfoil <eric at ypass.net>, License: PHP-3.01)
seemed right according to a quick “git grep -iP \(copyright\|licen\”
(disclaimer: I haven’t yet looked in detail myself). Please detail the
copyright file accurately. Please also double check the PHP-3.01
license, IIRC (but IMBR), the only Copyright allowed for it is “The PHP
Group”. Furthermore, package.xml documents the current license as LGPL,
so please, check with upstream what is it really supposed to be
(Upstream-Contact will be useful ;).

I don’t think it would be wise to propose the package in its current
status to the FTPmaster before the important license issues get addressed.

Regards

David


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iQEcBAEBCAAGBQJSxeMYAAoJEAWMHPlE9r08JEMH/j6EFME9SAYWXQqx0jJxAWDU
GyajSqewn4cA1UTp3g0Mrfjb8L2SIIkWxKslgUPVgr1+U8Ymda27dOuZhNuoI6Um
8K8GqBeQFdQdlkVl1DbjaLQ6DFB9O9UyLw/D/Jw+fKgvNfw59DlnklELXle+tsV8
8HeBOzAxtED4U/15cG2jGgUzp8vVPN3I4xPRQ+qaPhMdyUSI2SmgVUYcErvQAQDe
NTPUsefWATTPzQrXkKnWiy5OoW8mYeJJ9EULwFf6eNtDPqyr7ZXp/qOmzATtjoJb
B4fl6Hr3kUpcqdjDfYm93tdoQD3eVDQdJ8P/uhCy26KISWUNsHuxu35opheWBlE=
=Qe+Y
-----END PGP SIGNATURE-----