[pkg-php-pear] RFS: php-net-dnsbl and php-net-dns

[David Prévot]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

Le 02/01/2014 04:38, Prach Pongpanich a écrit :

> [2] http://anonscm.debian.org/gitweb/?p=pkg-php/php-net-dnsbl.git

I guess it would be wise to wait for the php-net-dns upload before
pushing this one, but here are a few comments about it after a quick
overlook:

The synopsis should be “a noun phrase […], as opposed to a verb phrase”
so please don’t start it with “checks”:

http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-synopsis

It might be better to patch package.xml instead of not using
${phppear:summary}, making it easier to forward improvements upstream,
and forcing one to double check if the summary changes later.

examples/check_dnsbl dnsbl *might* be of interest.

As for php-net-dnsbl, please fix the copyright syntax, and more
important, the copyright holder does not comply with the first point of
the license, please get it addressed with upstream.

Regards

David


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iQEcBAEBCAAGBQJSxexZAAoJEAWMHPlE9r08JRgH/jDJbSAA6YWcavcjsU5gHgR8
vP+rdyf+mH/3dt+5/koKSnXSaqGHuJvGVss/tPN1Ubbs2lLZVi1cINrYToLON/qf
kilvkkMsGTDhJ2yLTD8GOZwkg5JT04NVqUEIBnPxeENELuCX0CmSGYmwl0xCkIiY
anUa2Vm+M8zB2UBVSxpJtblJN0UZVGtQCjTToFZjnrvOBgjXA6w5PDgxOsF9sG14
idXvCEeaaxw0A1kGHBz6R+hAT1Z7anO3mpa5vsZ4FaRLXTE3NFELznLb/L3vnVnW
yc935C5Osf9nhMYnorTpjDo+eUTOUsnZAN2dPdAjDCfs60T3sk2do1SFEGc7JC4=
=cKs7
-----END PGP SIGNATURE-----