[pkg-php-pear] symfony copyright review

[Daniel Beyer]

Hi David,

On Sat, 2014-09-20 at 11:43 -0400, David Prévot wrote:
> Hi Daniel,
> 
> Le 16/09/2014 13:33, Daniel Beyer a écrit :
> 
> > I finally managed to deal
> > with the licensing of any image found in the symfony src.
> 
> Thanks for your work on the clarifying the licenses, looks like it was
> a lot more work than expected, kudos!
> 

Thanks, it really was a cruel task.


> I’ve just pushed two more minor fixes (DEP-3, and package replacement).
> 

Thanks!


> > If you up for a review of the licensing of the images, I suggest to run:
> > # ./debian/licensing/bin/check_image_licenses \
> >      --generate-html-image-index
> 
> I believe you made a more precise job on this one that I would ever have
> done myself, and am thus willing to trust you on that final part.
> 

Okay :-)


> > PS: I now care about having tests run during build of the package +
> > DEP-8.
> 
> About your WIP test branch, I didn’t dive into to it yet (i.e., I’ve not
> even try to run them), but here are two more details you may wish to
> handle:
> 
> - 744df86 (Do not Build-Depends: php-symfony-icu) is useless, since
>   php-symfony-intl anyway depends on it (feel free to build it directly
>   from Git in the mean time for your local tests).

You are right, but as I just tried it, I came across a "chicken or the
egg problem" ("l'éternel problème de l'oeuf et de la poule"):
* php-symfony-icu depends on php-symfony-intl
* php-symfony-intl is build out of src:symfony
* src:symfony build-depends on php-symfony-icu
For that I think it is better to omit this build dependency for now. I
pushed a branch 're-enable-symfony-icu-needing-tests', containing a
single reverting commit for that. 


> - c448974 should not add a Testsuite field since it’s now automatically
>   added by dpkg at build time.
> 

Thanks for the hint, I just dropped that field out of the commit.

BTW: I'm constantly rebasing my WIP branches. I name them differently in
future, so it gets clear one better does not push commits in them.


> Thanks again for your work on Symfony, please keep up posted if you need
> help on any specific stuff, or of course when things are ready.
> 

I just merged the WIP branch into master. Please note that BTS #762095
prevents the test from running at all (and I really was not in the mood
to disable a huge bunch of tests in symfony to work around this issue).
I already attached a patch to #762095, so closing this in time should
not be a problem.


> I may update some php-symfony-* packages in the mean time in case we’re
> not able to upload this one in time to be processed by ftp-masters until
> the freeze, and intend to use the latest 2.3.XX version (where XX seems
> to be 19 currently, and version them as 2.3.XX-1~sid1 in order to be
> upgraded to the proper 2.3.XX-1 from symfony as soon as it will make it
> out of NEW (I wonder if I should push the php-symfony2-yaml to
> php-symfony-yaml transition already, maybe in a ~sid2 version once I’m
> done with the other updates).
> 

Sounds reasonable to me. I have some input regarding the
php-symfony2-yaml to php-symfony-yaml transition. I'll write a separate
mail later tonight or tomorrow in the morning (depending on when I'm
back home).


Greetings
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20140920/b5ae752c/attachment.sig>