[pkg-php-pear] symfony: New version (2.7.4+dfsg-1) ready for review
david at tilapin.org
Mon Sep 14 15:57:10 UTC 2015
> I managed to finish with the work to prepare a new upstream version of
> Symfony, which I started on DebConf15.
Thats great! I just had a quick look at it, and it looks fine, thanks.
> 2. Include tests in autoload.php files
> Even we do not ship tests, the static autoload.php generated by phpab
> now include them. This is needed to be able to use the autoload.php
> generated by phpab to run tests. I don't like it much, but since we do
> not ship tests, it should not harm either.
I was afraid this might get in the way of packages that depends on Symfony
stuff for their own tests, but indeed, it looks harmless according to some
tests. The main downside might be too much useless lines in those static
autoloader, but we can certainly live with that in the mean time. Maybe we
could build two autoloader per package, one for the internal test suite,
and one for the deb (I might have a look at that if I find enough time).
On the bright side, the tests seem to be running even if the latest
version of php-symfony-* packages are not installed on the system.
> You can find my work in branch review/2.7.4 in the Debian packaging git
> repository . It would be great if you could double check it before
> merging it into master, updating the changelog and doing an upload,
I should have time for a closer look at it next weekend, maybe even during
the week (less sure). I pushed a few details on review/2.7.4 in the mean
time, feel free to tell me if some of them are not relevant.
Another detail: aff6b052ad could have been less noisy if the new patch
were added after the existing ones (avoiding a renaming of all the other
ones), or even if the vendor/autoload.php was added in the debian
directory (might be easier to edit a file than a patch). Looks like the
php-swiftmailer b-d was silently added with this change too (not sure if
it was on purpose).
More information about the pkg-php-pear