[pkg-php-pear] symfony: New version (2.7.4+dfsg-1) ready for review

Daniel Beyer dabe at deb.ymc.ch
Tue Sep 29 04:25:35 UTC 2015

Hi David,

On Mon, 2015-09-28 at 22:47 -0400, "David Prévot" wrote:
> Hi Daniel,
> I forgot one detail, sorry.

Don't worry ;)

> >> Looks like the
> >> php-swiftmailer b-d was silently added with this change too (not sure if
> >> it was on purpose).
> [...]
> > The new b-d php-swiftmailer is actually really needed. I made an
> > explicit commit for it.
> OK, thanks. Can you please push it upstream (e.g., adding
> swiftmailer/swiftmailer to require-dev of the main composer.json) if
> relevant?

Actually it is not an upstream issue and Swiftmailer is not needed to
run upstream's testsuite  at all. The (deprecated since 2.4)
swiftmailer-bridge even ships without any test.

This issue arises for us because of the way we do the autoloading.
Looking in d/php-symfony-swiftmailer-bridge.autoload.php.tpl there is:
require_once 'Swift/swift_required.php';

Looking at this, the best solution would be to not add a b-d for
php-swiftmailer. Instead we simply should not include
Symfony/Bridge/Swiftmailer/autoload.php in the
debian/autoload.{build,DEP-8}.php files.

I'll just opened up a new wip/dabe/2.7.5 branch, containing this and
other changes. I'll push it soon.

Do you have any pending changes on top of the review/2.7.5 branch?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20150929/3dff7105/attachment.sig>

More information about the pkg-php-pear mailing list