[pkg-php-pear] symfony: New version (2.7.4+dfsg-1) ready for review

David Prévot david at tilapin.org
Tue Sep 29 12:50:06 UTC 2015


Hi Daniel,

Le 29/09/2015 00:25, Daniel Beyer a écrit :
> On Mon, 2015-09-28 at 22:47 -0400, "David Prévot" wrote:

>>>> Looks like the
>>>> php-swiftmailer b-d was silently added with this change too (not sure if
>>>> it was on purpose).
>> [...]
>>> The new b-d php-swiftmailer is actually really needed. I made an
>>> explicit commit for it.
>>
>> OK, thanks. Can you please push it upstream (e.g., adding
>> swiftmailer/swiftmailer to require-dev of the main composer.json) if
>> relevant?
[…]
> Actually it is not an upstream issue and Swiftmailer is not needed to
> run upstream's testsuite  at all. The (deprecated since 2.4)
> swiftmailer-bridge even ships without any test.

Ho, ok. I guess it’s fine to install dependencies of the packages we’re
building for running the tests anyway (that’s what we usually need to do).

> Looking at this, the best solution would be to not add a b-d for
> php-swiftmailer. Instead we simply should not include
> Symfony/Bridge/Swiftmailer/autoload.php in the
> debian/autoload.{build,DEP-8}.php files.

As you prefer. Please note that dependencies will anyway be installed
for DEP-8 (since the package will be installed).

> Do you have any pending changes on top of the review/2.7.5 branch?

I forgot to push another detail yesterday, done now.

Regards

David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20150929/c5bff14f/attachment.sig>


More information about the pkg-php-pear mailing list