[pkg-php-pear] symfony: New version (2.7.4+dfsg-1) ready for review

Daniel Beyer dabe at deb.ymc.ch
Wed Sep 30 07:37:00 UTC 2015

Hi David,

On Mon, 2015-09-28 at 22:27 -0400, "David Prévot" wrote:
> Hi Daniel,
> > It would be great if you find the time to review the review/2.7.5 branch,
> I managed to have a look at your commits and the general debian/ diff from
> the last version. I only have one question: why are the changes to
> debian/php-symfony-security-bundle.autoload.php.tpl (in a40261b) needed?

That commit actually did more than what was mentioned in its message:
1. Include tests in autoloads
2. Remove the "move away two of the generated autoload.php files"
3. Load additionally classes in SecurityBundle's autoload.php

I started to split this in three different commit, but then I thought
> Aren’t the relevant Symfony/Bundle/*/autoload.php loaded anyway via the
> vendor/autoload.php one?

I checked this and found out that vendor/autoload.php in that case is
not used at all:
Some functional tests start new php processes, which makes use of an
AppKernel.php [1,2], which comes with some outdated autoload.php
detection code. This code, identical in both AppKernel.php files, did
not load vendor/autoload.php, but instead:

For us this clearly is wrong and needs (IMHO) to be corrected in the
Symfony src. Thus I added a new patch [3], which I intend to provide
upstream as soon as I find time.

> > update the changelog, merge into master, etc. and do an upload
> > to the Debian archives, if you think it is ready.
> I try to get through the upstream diff ASAP and do that, thanks for your
> work on this big package!

Thanks for all your work here. But sorry to tell you, that there is a
new review branch (note that "B-"):

Let's try to get this into the archives and back into master afterwards.
But please don't hurry, as long this is done before upstream does a new
release, I'm just happy. (But if I need to rebase/rework those commits
once more, I might go coo-coo... ;-)


[1] http://anonscm.debian.org/cgit/pkg-php/symfony.git/tree/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/app/AppKernel.php?h=review/B-2.7.5#n19
[2] http://anonscm.debian.org/cgit/pkg-php/symfony.git/tree/src/Symfony/Bundle/SecurityBundle/Tests/Functional/app/AppKernel.php?h=review/B-2.7.5#n19
[3] http://anonscm.debian.org/cgit/pkg-php/symfony.git/tree/debian/patches/FrameworkBundle-SecurityBundle-Don-t-try-to-include-.patch?h=review/B-2.7.5

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20150930/b28be871/attachment.sig>

More information about the pkg-php-pear mailing list